From: "Dmitry V. Levin" <ldv@altlinux.org>
To: David Sterba <dsterba@suse.com>
Cc: Chris Mason <clm@fb.com>, Jeff Mahoney <jeffm@suse.com>,
Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h
Date: Thu, 2 Mar 2017 16:01:17 +0300 [thread overview]
Message-ID: <20170302130117.GA2208@altlinux.org> (raw)
In-Reply-To: <20170302114212.GK4662@suse.cz>
On Thu, Mar 02, 2017 at 12:42:12PM +0100, David Sterba wrote:
> On Wed, Mar 01, 2017 at 03:54:35PM +0100, David Sterba wrote:
> > On Wed, Mar 01, 2017 at 02:12:50AM +0300, Dmitry V. Levin wrote:
> > > btrfs_err_str function is not called from anywhere and is replicated
> > > in the userspace headers for btrfs-progs.
> > >
> > > It's removal also fixes the following linux/btrfs.h userspace
> > > compilation error:
> > >
> > > /usr/include/linux/btrfs.h: In function 'btrfs_err_str':
> > > /usr/include/linux/btrfs.h:740:11: error: 'NULL' undeclared (first use in this function)
> > > return NULL;
> > >
> > > Suggested-by: Jeff Mahoney <jeffm@suse.com>
> > > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> > > Reviewed-by: David Sterba <dsterba@suse.com>
> > > ---
> > > v3: the patch seems to be lost, resending with updated list of addressees
> >
> > Indeed, I can't find how or where it got lost, sorry. Added to 4.11
> > again.
>
> So it's because you did not CC linux-btrfs@ , I have the mails in my
> inbox but haven't found it in the other folder while picking patches.
Thanks, I though so when Cc'ed linux-btrfs@ the last time.
Consider updating MAINTAINERS file so that scripts/get_maintainer.pl
would be able to print the right addressees for btrfs header files:
diff --git a/MAINTAINERS b/MAINTAINERS
index 0001835..04a758f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2905,4 +2905,6 @@ S: Maintained
F: Documentation/filesystems/btrfs.txt
F: fs/btrfs/
+F: include/linux/btrfs*
+F: include/uapi/linux/btrfs*
BTTV VIDEO4LINUX DRIVER
--
ldv
next prev parent reply other threads:[~2017-03-02 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 20:02 [PATCH] uapi: fix linux/btrfs.h userspace compilation error Dmitry V. Levin
2017-02-15 20:36 ` Joe Perches
2017-02-15 21:24 ` Jeff Mahoney
2017-02-15 22:55 ` [PATCH v2] btrfs: remove btrfs_err_str function from uapi/linux/btrfs.h Dmitry V. Levin
2017-02-16 14:15 ` David Sterba
2017-02-28 23:12 ` [PATCH v3] " Dmitry V. Levin
2017-03-01 14:54 ` David Sterba
2017-03-02 11:42 ` David Sterba
2017-03-02 13:01 ` Dmitry V. Levin [this message]
2017-03-02 18:59 ` David Sterba
2017-03-02 19:42 ` [PATCH] MAINTAINERS: add btrfs file entries Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302130117.GA2208@altlinux.org \
--to=ldv@altlinux.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).