* [PATCH] f2fs: correct cp_ver for compatibility to old image
@ 2017-03-02 3:22 Chao Yu
2017-03-02 18:55 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Chao Yu @ 2017-03-02 3:22 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, chao, Chao Yu
There is no CP_CRC_RECOVERY_FLAG tagged in checkpoint pack, calculate
cp_version as old format.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/node.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 6c027b6833f4..0d46404ca769 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -2507,7 +2507,9 @@ static int __get_nat_bitmaps(struct f2fs_sb_info *sbi)
f2fs_put_page(page, 1);
}
- cp_ver |= (cur_cp_crc(ckpt) << 32);
+ if (__is_set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG))
+ cp_ver |= (cur_cp_crc(ckpt) << 32);
+
if (cpu_to_le64(cp_ver) != *(__le64 *)nm_i->nat_bits) {
disable_nat_bits(sbi, true);
return 0;
--
2.8.2.295.g3f1c1d0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: correct cp_ver for compatibility to old image
2017-03-02 3:22 [PATCH] f2fs: correct cp_ver for compatibility to old image Chao Yu
@ 2017-03-02 18:55 ` Jaegeuk Kim
2017-03-06 10:23 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2017-03-02 18:55 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, linux-kernel, chao
On 03/02, Chao Yu wrote:
> There is no CP_CRC_RECOVERY_FLAG tagged in checkpoint pack, calculate
> cp_version as old format.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/node.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 6c027b6833f4..0d46404ca769 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -2507,7 +2507,9 @@ static int __get_nat_bitmaps(struct f2fs_sb_info *sbi)
> f2fs_put_page(page, 1);
> }
>
> - cp_ver |= (cur_cp_crc(ckpt) << 32);
> + if (__is_set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG))
> + cp_ver |= (cur_cp_crc(ckpt) << 32);
Well, we always write nat_bits with crc. So if it's different, something is
wrong and we need to drop it. CP-CRC_RECOVERY_FLAG is used for roll-forward
recovery, which is a different context.
> +
> if (cpu_to_le64(cp_ver) != *(__le64 *)nm_i->nat_bits) {
> disable_nat_bits(sbi, true);
> return 0;
> --
> 2.8.2.295.g3f1c1d0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: correct cp_ver for compatibility to old image
2017-03-02 18:55 ` Jaegeuk Kim
@ 2017-03-06 10:23 ` Chao Yu
0 siblings, 0 replies; 3+ messages in thread
From: Chao Yu @ 2017-03-06 10:23 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-f2fs-devel, linux-kernel, chao
On 2017/3/3 2:55, Jaegeuk Kim wrote:
> On 03/02, Chao Yu wrote:
>> There is no CP_CRC_RECOVERY_FLAG tagged in checkpoint pack, calculate
>> cp_version as old format.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/node.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
>> index 6c027b6833f4..0d46404ca769 100644
>> --- a/fs/f2fs/node.c
>> +++ b/fs/f2fs/node.c
>> @@ -2507,7 +2507,9 @@ static int __get_nat_bitmaps(struct f2fs_sb_info *sbi)
>> f2fs_put_page(page, 1);
>> }
>>
>> - cp_ver |= (cur_cp_crc(ckpt) << 32);
>> + if (__is_set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG))
>> + cp_ver |= (cur_cp_crc(ckpt) << 32);
>
> Well, we always write nat_bits with crc. So if it's different, something is
> wrong and we need to drop it.
Got it. :)
Thanks,
> CP-CRC_RECOVERY_FLAG is used for roll-forward recovery, which is a different context.
>
>> +
>> if (cpu_to_le64(cp_ver) != *(__le64 *)nm_i->nat_bits) {
>> disable_nat_bits(sbi, true);
>> return 0;
>> --
>> 2.8.2.295.g3f1c1d0
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-06 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-02 3:22 [PATCH] f2fs: correct cp_ver for compatibility to old image Chao Yu
2017-03-02 18:55 ` Jaegeuk Kim
2017-03-06 10:23 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).