From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751945AbdCCSQo (ORCPT ); Fri, 3 Mar 2017 13:16:44 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51982 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbdCCSQn (ORCPT ); Fri, 3 Mar 2017 13:16:43 -0500 Date: Fri, 03 Mar 2017 09:48:40 -0800 (PST) Message-Id: <20170303.094840.541547905439932719.davem@davemloft.net> To: dhowells@redhat.com Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] rxrpc: Fix potential NULL-pointer exception From: David Miller In-Reply-To: <148849717388.26285.3477243497908119377.stgit@warthog.procyon.org.uk> References: <148849717388.26285.3477243497908119377.stgit@warthog.procyon.org.uk> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 03 Mar 2017 09:48:41 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Howells Date: Thu, 02 Mar 2017 23:26:13 +0000 > Fix a potential NULL-pointer exception in rxrpc_do_sendmsg(). The call > state check that I added should have gone into the else-body of the > if-statement where we actually have a call to check. > > Found by CoverityScan CID#1414316 ("Dereference after null check"). > > Fixes: 540b1c48c37a ("rxrpc: Fix deadlock between call creation and sendmsg/recvmsg") > Reported-by: Colin Ian King > Signed-off-by: David Howells Applied.