From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751971AbdCCJxK (ORCPT ); Fri, 3 Mar 2017 04:53:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:56088 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbdCCJxD (ORCPT ); Fri, 3 Mar 2017 04:53:03 -0500 Date: Fri, 3 Mar 2017 09:04:20 +0100 From: Michal Hocko To: Peter Zijlstra Cc: Nikolay Borisov , linux-kernel@vger.kernel.org, vbabka.lkml@gmail.com, linux-mm@kvack.org, mingo@redhat.com Subject: Re: [PATCH v3] lockdep: Teach lockdep about memalloc_noio_save Message-ID: <20170303080419.GA31582@dhcp22.suse.cz> References: <1488367797-27278-1-git-send-email-nborisov@suse.com> <20170301154659.GL6515@twins.programming.kicks-ass.net> <20170301160529.GI11730@dhcp22.suse.cz> <20170301161220.GP6515@twins.programming.kicks-ass.net> <20170301161854.GJ11730@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170301161854.GJ11730@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 01-03-17 17:18:54, Michal Hocko wrote: > On Wed 01-03-17 17:12:20, Peter Zijlstra wrote: > > On Wed, Mar 01, 2017 at 05:05:30PM +0100, Michal Hocko wrote: > > > Anyway, does the following help? > > > > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > > > index 47e4f82380e4..d5386ad7ed3f 100644 > > > --- a/kernel/locking/lockdep.c > > > +++ b/kernel/locking/lockdep.c > > > @@ -47,6 +47,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > No, Ingo moved that to linux/sched/mm.h in tip/master, which was the > > problem. > > Yeah, have seen your email after I posted mine... > > > But I think this needs to go to Linus in this cycle, right? In which > > case Ingo gets to sort the fallout. > > Yes I think it would be better to send it sonner rahter than later. > People also might want to backport it to older kernels... Would you mind if I took this patch and route it via Andrew? I plan to resubmit my scope NOFS patchset [1] and [2] will need to be refreshed on top of it so it would be easier for me that way. [1] http://lkml.kernel.org/r/20170206140718.16222-1-mhocko@kernel.org [2] http://lkml.kernel.org/r/20170206140718.16222-4-mhocko@kernel.org -- Michal Hocko SUSE Labs