From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbdCCLYo (ORCPT ); Fri, 3 Mar 2017 06:24:44 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:33010 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbdCCLXn (ORCPT ); Fri, 3 Mar 2017 06:23:43 -0500 Date: Fri, 3 Mar 2017 10:29:58 +0100 From: Alexandre Belloni To: Thomas Petazzoni Cc: Guenter Roeck , linux-watchdog@vger.kernel.org, Wenyou.Yang@microchip.com, linux-kernel@vger.kernel.org, Nicolas Ferre , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/4] watchodg: sama5d4: simplify probe Message-ID: <20170303092958.2phrxelq3xqojns7@piout.net> References: <20170302173114.28508-1-alexandre.belloni@free-electrons.com> <20170302173114.28508-4-alexandre.belloni@free-electrons.com> <20170303090325.41b9ce64@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303090325.41b9ce64@free-electrons.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2017 at 09:03:25 +0100, Thomas Petazzoni wrote: > On Thu, 2 Mar 2017 18:31:13 +0100, Alexandre Belloni wrote: > > > + irq = irq_of_parse_and_map(pdev->dev.of_node, 0); > > Any reason to use irq_of_parse_and_map() over the more conventional > platform_get_irq() ? > No particular reason but I'm just removing the if (pdev->dev.of_node) -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com