From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751828AbdCCLYI (ORCPT ); Fri, 3 Mar 2017 06:24:08 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:42693 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751578AbdCCLXr (ORCPT ); Fri, 3 Mar 2017 06:23:47 -0500 Date: Fri, 3 Mar 2017 11:47:13 +0100 From: Sascha Hauer To: Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Maxime Ripard , Shawn Guo , Fabio Estevam , kernel@pengutronix.de, Rob Herring , Mark Rutland , Michael Grzeschik Subject: Re: [PATCH 1/2] nvmem: Add driver for the i.MX IIM Message-ID: <20170303104713.p25bzw4exjavjlti@pengutronix.de> References: <20170213153149.11710-1-s.hauer@pengutronix.de> <20170213153149.11710-2-s.hauer@pengutronix.de> <568bbe58-0bb5-f7ec-a646-271912a4313a@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:47:02 up 70 days, 19:05, 30 users, load average: 0.11, 0.07, 0.03 User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 03, 2017 at 09:54:07AM +0000, Srinivas Kandagatla wrote: > > > On 03/03/17 09:50, Srinivas Kandagatla wrote: > > > > > > On 13/02/17 15:31, Sascha Hauer wrote: > > > From: Michael Grzeschik > > > > > > This adds a readonly nvmem driver for the i.MX IC Identification Module > > > (IIM). The IIM is found on the older i.MX SoCs like the i.MX25, i.MX27, > > > i.MX31, i.MX35, i.MX51 and the i.MX53. > > > > > > The IIM can control up to 8 fuse banks with 256 bit each. Not all of the > > > banks are equipped on the different SoCs. The actual number of fuses > > > differ from 512 on the i.MX27 and 1152 on the i.MX53. > > > > > > The fuses are one time writable, but writing is currently not supported > > > in the driver. > > > > > > Signed-off-by: Michael Grzeschik > > > Signed-off-by: Sascha Hauer > > > > > > > --- > > > drivers/nvmem/Kconfig | 11 ++++ > > > drivers/nvmem/Makefile | 2 + > > > drivers/nvmem/imx-iim.c | 171 > > > ++++++++++++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 184 insertions(+) > > > create mode 100644 drivers/nvmem/imx-iim.c > > > > Patch looks good to me, Will pick both bindings and this patch in next > > cycle for 4.12. > Opps sent email too quick.. > > Can you also make sure that ids are null terminated as reported by kbuild > https://www.spinics.net/lists/arm-kernel/msg562543.html in next version. > Thanks for looking. I just sent the v2 series. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |