From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751571AbdCDIQB (ORCPT ); Sat, 4 Mar 2017 03:16:01 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36523 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbdCDIP7 (ORCPT ); Sat, 4 Mar 2017 03:15:59 -0500 Date: Sat, 4 Mar 2017 10:15:04 +0200 From: Krzysztof Kozlowski To: Sergio Prado Cc: kgene@kernel.org, javier@osg.samsung.com, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: samsung: fix segfault when using external interrupts on s3c24xx Message-ID: <20170304081504.unv6sihbmp76ynfy@kozik-lap> References: <1488489799-18136-1-git-send-email-sergio.prado@e-labworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1488489799-18136-1-git-send-email-sergio.prado@e-labworks.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 02, 2017 at 06:23:19PM -0300, Sergio Prado wrote: > We are getting a NULL pointer dereference when working with external > interrupts on s3c24xx: > > Unable to handle kernel NULL pointer dereference at virtual address 000000a8 > pgd = c0104000 > [000000a8] *pgd=00000000 > Internal error: Oops: 5 [#1] ARM > Modules linked in: > CPU: 0 PID: 0 Comm: swapper Not tainted 4.10.0-rc8mini2440-sub-00047-g0722f57bfae9-dirty #3 > Hardware name: Samsung S3C2416 (Flattened Device Tree) > task: c07399f8 task.stack: c0734000 > PC is at s3c24xx_demux_eint4_7+0x24/0x10c > LR is at s3c24xx_demux_eint4_7+0x108/0x10c > > The problem is in the function s3c24xx_demux_eint() when dereferencing > bank->eint_base. > > At this point, we cannot get the bank pointer from the irq_desc > structure since it is pointing to the hardware irq, not virq. > > So let's get the bank pointer directly from data->drvdata. > > This is a regression from commit 8b1bd11c1f8f529057369c5b3702d13fd24e2765. Checkpatch should complain here about commit format. > > Tested on FriendlyARM mini2440. > Please add: Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank") Cc: > Signed-off-by: Sergio Prado > --- > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > index b82a003546ae..1b8d887796e8 100644 > --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > @@ -356,8 +356,8 @@ static inline void s3c24xx_demux_eint(struct irq_desc *desc, > { > struct s3c24xx_eint_data *data = irq_desc_get_handler_data(desc); > struct irq_chip *chip = irq_desc_get_chip(desc); > - struct irq_data *irqd = irq_desc_get_irq_data(desc); > - struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd); > + struct samsung_pinctrl_drv_data *d = data->drvdata; > + struct samsung_pin_bank *bank = d->pin_banks; I think 'pin_banks' point to all banks of given controller not to the currently accessed one. Best regards, Krzysztof