From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294AbdCERKS (ORCPT ); Sun, 5 Mar 2017 12:10:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45666 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbdCERKR (ORCPT ); Sun, 5 Mar 2017 12:10:17 -0500 Date: Sun, 5 Mar 2017 18:01:24 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 01/10] perf, tools, stat: Factor out callback for collecting event values Message-ID: <20170305170124.GA20686@krava> References: <20170301064924.32172-1-andi@firstfloor.org> <20170301064924.32172-2-andi@firstfloor.org> <20170303103303.GA8905@krava> <20170303231610.GK26852@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303231610.GK26852@two.firstfloor.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sun, 05 Mar 2017 17:01:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 03, 2017 at 03:16:11PM -0800, Andi Kleen wrote: > On Fri, Mar 03, 2017 at 11:33:03AM +0100, Jiri Olsa wrote: > > On Tue, Feb 28, 2017 at 10:49:15PM -0800, Andi Kleen wrote: > > > > SNIP > > > > > +static void collect_data(struct perf_evsel *counter, > > > + void (*cb)(struct perf_evsel *counter, void *data, > > > + bool first), > > > + void *data) > > > +{ > > > + cb(counter, data, true); > > > +} > > > + > > > +struct aggr_data { > > > + u64 ena, run, val; > > > + int id; > > > + int nr; > > > + int cpu; > > > +}; > > > + > > > +static void aggr_cb(struct perf_evsel *counter, void *data, bool first) > > > +{ > > > + struct aggr_data *ad = data; > > > + int cpu, cpu2, s2; > > > + > > > + for (cpu = 0; cpu < perf_evsel__nr_cpus(counter); cpu++) { > > > + struct perf_counts_values *counts; > > > + > > > + cpu2 = perf_evsel__cpus(counter)->map[cpu]; > > > + s2 = aggr_get_id(evsel_list->cpus, cpu2); > > > > that does not match the removed code.. why? > > s2 = aggr_get_id(perf_evsel__cpus(counter), cpu); > > I added it at some point during debugging. I think it's > actually a nop here, but technically it's correct (we're > always supposed to remap) > > I can remove it, but it's really a small code cleanup. please do, thanks jirka