From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbdCFNZK (ORCPT ); Mon, 6 Mar 2017 08:25:10 -0500 Received: from mail-qk0-f196.google.com ([209.85.220.196]:33210 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752820AbdCFNYn (ORCPT ); Mon, 6 Mar 2017 08:24:43 -0500 Date: Mon, 6 Mar 2017 09:15:16 -0400 From: Sergio Prado To: Krzysztof Kozlowski Cc: kgene@kernel.org, javier@osg.samsung.com, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: samsung: fix segfault when using external interrupts on s3c24xx Message-ID: <20170306131516.GA6095@n1> References: <1488489799-18136-1-git-send-email-sergio.prado@e-labworks.com> <20170304081504.unv6sihbmp76ynfy@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170304081504.unv6sihbmp76ynfy@kozik-lap> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, > > This is a regression from commit 8b1bd11c1f8f529057369c5b3702d13fd24e2765. > > Checkpatch should complain here about commit format. > > > > > Tested on FriendlyARM mini2440. > > > > Please add: > Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank") > Cc: > OK. > > Signed-off-by: Sergio Prado > > --- > > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > > index b82a003546ae..1b8d887796e8 100644 > > --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > > +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c > > @@ -356,8 +356,8 @@ static inline void s3c24xx_demux_eint(struct irq_desc *desc, > > { > > struct s3c24xx_eint_data *data = irq_desc_get_handler_data(desc); > > struct irq_chip *chip = irq_desc_get_chip(desc); > > - struct irq_data *irqd = irq_desc_get_irq_data(desc); > > - struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd); > > + struct samsung_pinctrl_drv_data *d = data->drvdata; > > + struct samsung_pin_bank *bank = d->pin_banks; > > I think 'pin_banks' point to all banks of given controller not to the > currently accessed one. Understood. I think it worked in my tests because on s3c2440 all banks have the same eint base address. So what do you think is the best approach to solve this problem? > > > Best regards, > Krzysztof > -- Sergio Prado Embedded Labworks Office: +55 11 2628-3461 Mobile: +55 11 97123-3420