From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932272AbdCFOSt (ORCPT ); Mon, 6 Mar 2017 09:18:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:34737 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753665AbdCFOSU (ORCPT ); Mon, 6 Mar 2017 09:18:20 -0500 Date: Mon, 6 Mar 2017 14:38:33 +0100 From: Michal Hocko To: Andrew Morton Cc: Xishi Qiu , Vlastimil Babka , Mel Gorman , Minchan Kim , Joonsoo Kim , Yisheng Xie , Linux MM , LKML Subject: Re: [PATCH 1/2] mm: use is_migrate_highatomic() to simplify the code Message-ID: <20170306133832.GE27953@dhcp22.suse.cz> References: <58B94F15.6060606@huawei.com> <20170303131808.GH31499@dhcp22.suse.cz> <20170303150619.4011826c7e645c0725efd6ae@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303150619.4011826c7e645c0725efd6ae@linux-foundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 03-03-17 15:06:19, Andrew Morton wrote: > On Fri, 3 Mar 2017 14:18:08 +0100 Michal Hocko wrote: > > > On Fri 03-03-17 19:10:13, Xishi Qiu wrote: > > > Introduce two helpers, is_migrate_highatomic() and is_migrate_highatomic_page(). > > > Simplify the code, no functional changes. > > > > static inline helpers would be nicer than macros > > Always. > > We made a big dependency mess in mmzone.h. internal.h works. Just too bad we have three different header files for is_migrate_isolate{_page} - include/linux/page-isolation.h is_migrate_cma{_page} - include/linux/mmzone.h is_migrate_highatomic{_page} - mm/internal.h I guess we want all of them in internal.h? -- Michal Hocko SUSE Labs