From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752161AbdCHJy2 (ORCPT ); Wed, 8 Mar 2017 04:54:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:52818 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345AbdCHJyL (ORCPT ); Wed, 8 Mar 2017 04:54:11 -0500 Date: Wed, 8 Mar 2017 10:18:03 +0100 From: Michal Hocko To: Vlastimil Babka Cc: Minchan Kim , Anshuman Khandual , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, "Kirill A . Shutemov" , Johannes Weiner , Chen Gang Subject: Re: [PATCH] mm: Do not use double negation for testing page flags Message-ID: <20170308091802.GA11028@dhcp22.suse.cz> References: <1488868597-32222-1-git-send-email-minchan@kernel.org> <8b5c4679-484e-fe7f-844b-af5fd41b01e0@linux.vnet.ibm.com> <20170308052555.GB11206@bbox> <6f9274f7-6d2e-60a6-c36a-78f8f79004aa@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f9274f7-6d2e-60a6-c36a-78f8f79004aa@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 08-03-17 08:51:23, Vlastimil Babka wrote: > On 03/08/2017 06:25 AM, Minchan Kim wrote: [...] > > Although we can add a little description > > somewhere in page-flags.h, I believe changing to boolean is more > > clear/not-error-prone so Chen's work is enough worth, I think. > > Agree, unless some arches benefit from the int by performance > for some reason (no idea if it's possible). I have a vague recollection somebody tried to change this to bool and the resulting code was larger on some architecture. Do not remember any details though Btw. feel free to add Acked-by: Michal Hocko -- Michal Hocko SUSE Labs