From: Mark Rutland <mark.rutland@arm.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Will Deacon <will.deacon@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Ingo Molnar <mingo@redhat.com>,
kasan-dev <kasan-dev@googlegroups.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86, kasan: add KASAN checks to atomic operations
Date: Wed, 8 Mar 2017 15:43:57 +0000 [thread overview]
Message-ID: <20170308154357.GB13133@leverpostej> (raw)
In-Reply-To: <CACT4Y+bZqiE9Mxq1y4vdyT6=DCq0L+y_HjBH1=RJf5C9134CwQ@mail.gmail.com>
On Wed, Mar 08, 2017 at 04:27:11PM +0100, Dmitry Vyukov wrote:
> On Wed, Mar 8, 2017 at 4:20 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > As in my other reply, I'd prefer that we wrapped the (arch-specific)
> > atomic implementations such that we can instrument them explicitly in a
> > core header. That means that the implementation and semantics of the
> > atomics don't change at all.
> >
> > Note that we could initially do this just for x86 and arm64), e.g. by
> > having those explicitly include an <asm-generic/atomic-instrumented.h>
> > at the end of their <asm/atomic.h>.
>
> How exactly do you want to do this incrementally?
> I don't feel ready to shuffle all archs, but doing x86 in one patch
> and then arm64 in another looks tractable.
I guess we'd have three patches: one adding the header and any core
infrastructure, followed by separate patches migrating arm64 and x86
over.
Thanks,
Mark.
next prev parent reply other threads:[~2017-03-08 15:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 12:42 [PATCH] x86, kasan: add KASAN checks to atomic operations Dmitry Vyukov
2017-03-06 12:50 ` Dmitry Vyukov
2017-03-06 12:58 ` Peter Zijlstra
2017-03-06 13:01 ` Peter Zijlstra
2017-03-06 14:24 ` Dmitry Vyukov
2017-03-06 15:20 ` Peter Zijlstra
2017-03-06 16:04 ` Mark Rutland
2017-03-06 15:33 ` Peter Zijlstra
2017-03-06 16:20 ` Mark Rutland
2017-03-06 16:27 ` Dmitry Vyukov
2017-03-06 17:25 ` Mark Rutland
2017-03-06 20:35 ` Peter Zijlstra
2017-03-08 13:42 ` Dmitry Vyukov
2017-03-08 15:20 ` Mark Rutland
2017-03-08 15:27 ` Dmitry Vyukov
2017-03-08 15:43 ` Mark Rutland [this message]
2017-03-08 15:45 ` Dmitry Vyukov
2017-03-08 15:48 ` Mark Rutland
2017-03-08 17:43 ` Will Deacon
2017-03-14 15:22 ` Dmitry Vyukov
2017-03-14 15:31 ` Peter Zijlstra
2017-03-14 15:32 ` Peter Zijlstra
2017-03-14 15:44 ` Mark Rutland
2017-03-14 19:25 ` Dmitry Vyukov
2017-03-06 16:48 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308154357.GB13133@leverpostej \
--to=mark.rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).