From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sergio Prado <sergio.prado@e-labworks.com>
Cc: kgene@kernel.org, javier@osg.samsung.com, tomasz.figa@gmail.com,
s.nawrocki@samsung.com, linus.walleij@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: samsung: fix segfault when using external interrupts on s3c24xx
Date: Wed, 8 Mar 2017 18:34:34 +0200 [thread overview]
Message-ID: <20170308163434.obhtg6fwmjwqv7jm@kozik-lap> (raw)
In-Reply-To: <20170306131516.GA6095@n1>
On Mon, Mar 06, 2017 at 09:15:16AM -0400, Sergio Prado wrote:
> Hi Krzysztof,
>
> > > This is a regression from commit 8b1bd11c1f8f529057369c5b3702d13fd24e2765.
> >
> > Checkpatch should complain here about commit format.
> >
> > >
> > > Tested on FriendlyARM mini2440.
> > >
> >
> > Please add:
> > Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple IORESOURCE_MEM for one pin-bank")
> > Cc: <stable@vger.kernel.org>
> >
>
> OK.
>
> > > Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> > > ---
> > > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> > > index b82a003546ae..1b8d887796e8 100644
> > > --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> > > +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> > > @@ -356,8 +356,8 @@ static inline void s3c24xx_demux_eint(struct irq_desc *desc,
> > > {
> > > struct s3c24xx_eint_data *data = irq_desc_get_handler_data(desc);
> > > struct irq_chip *chip = irq_desc_get_chip(desc);
> > > - struct irq_data *irqd = irq_desc_get_irq_data(desc);
> > > - struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd);
> > > + struct samsung_pinctrl_drv_data *d = data->drvdata;
> > > + struct samsung_pin_bank *bank = d->pin_banks;
> >
> > I think 'pin_banks' point to all banks of given controller not to the
> > currently accessed one.
>
> Understood. I think it worked in my tests because on s3c2440 all banks
> have the same eint base address.
>
> So what do you think is the best approach to solve this problem?
Maybe you can get to this through:
s3c24xx_eint_domain_data = s3c24xx_eint_data->domains[virq].host_data;
s3c24xx_eint_domain_data->bank
It is getting slightly more complicated...
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-03-08 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 21:23 [PATCH] pinctrl: samsung: fix segfault when using external interrupts on s3c24xx Sergio Prado
2017-03-04 8:15 ` Krzysztof Kozlowski
2017-03-04 11:45 ` Tomasz Figa
2017-03-06 13:15 ` Sergio Prado
2017-03-08 16:34 ` Krzysztof Kozlowski [this message]
2017-03-09 5:56 ` Tomasz Figa
2017-03-09 6:42 ` Krzysztof Kozlowski
2017-03-21 1:31 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308163434.obhtg6fwmjwqv7jm@kozik-lap \
--to=krzk@kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sergio.prado@e-labworks.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).