From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: netdev@vger.kernel.org, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets
Date: Thu, 09 Mar 2017 09:38:51 -0800 (PST) [thread overview]
Message-ID: <20170309.093851.1057108507009455288.davem@davemloft.net> (raw)
In-Reply-To: <21773.1489045894@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Thu, 09 Mar 2017 07:51:34 +0000
> David Miller <davem@davemloft.net> wrote:
>
>> I guess this is fine, but I think you can use one of the two "sk_padding"
>> bits in struct sock instead of making the structure larger.
>
> It shouldn't make the structure larger since there's a hole in the structure:
...
> u16 sk_gso_max_segs;
> ---> 2-byte hole here
> unsigned long sk_lingertime;
>
> but I'll quite happily shift it to sk_padding.
Ok, then that's fine.
prev parent reply other threads:[~2017-03-09 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 15:04 [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets David Howells
2017-03-09 7:06 ` David Miller
2017-03-09 7:51 ` David Howells
2017-03-09 17:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309.093851.1057108507009455288.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).