From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932113AbdCILHW (ORCPT ); Thu, 9 Mar 2017 06:07:22 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:35049 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754574AbdCILHT (ORCPT ); Thu, 9 Mar 2017 06:07:19 -0500 Date: Thu, 9 Mar 2017 11:59:34 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mike Turquette , Stephen Boyd , dri-devel , Daniel Vetter , David Airlie , Mark Rutland , Rob Herring , devicetree , linux-clk , linux-arm-kernel , linux-kernel , linux-sunxi Subject: Re: [linux-sunxi] [PATCH 14/15] ARM: sun5i: a10s: Add the HDMI controller node Message-ID: <20170309105934.ahsussan6p36lrzn@lukather> References: <61406c0ba992f2fa5b5180b790a1ef3fa38d9567.1488876832.git-series.maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ikoiozqmyzngxi4v" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ikoiozqmyzngxi4v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable 1;4601;0c On Wed, Mar 08, 2017 at 11:35:39AM +0800, Chen-Yu Tsai wrote: > Hi, >=20 > On Tue, Mar 7, 2017 at 4:56 PM, Maxime Ripard > wrote: > > The A10s has an HDMI controller connected to the second TCON channel. A= dd > > it to our DT. > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm/boot/dts/sun5i-a10s.dtsi | 34 +++++++++++++++++++++++++++++++= +- > > arch/arm/boot/dts/sun5i.dtsi | 1 +- > > 2 files changed, 35 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/sun5i-a10s.dtsi b/arch/arm/boot/dts/sun5= i-a10s.dtsi > > index 074485782a4a..3482c9d2b120 100644 > > --- a/arch/arm/boot/dts/sun5i-a10s.dtsi > > +++ b/arch/arm/boot/dts/sun5i-a10s.dtsi > > @@ -72,7 +72,33 @@ > > }; > > }; > > > > + display-engine { > > + compatible =3D "allwinner,sun5i-a10s-display-engine", > > + "allwinner,sun5i-a13-display-engine"; > > + allwinner,pipelines =3D <&fe0>; > > + }; > > + > > soc@01c00000 { > > + hdmi0: hdmi@01c16000 { >=20 > Nit: is the 0 suffix needed? I don't see any indication that there is > a second controller. >=20 > > + compatible =3D "allwinner,sun5i-a10s-hdmi"; > > + reg =3D <0x01c16000 0x1000>; > > + clocks =3D <&ccu CLK_AHB_HDMI>, <&ccu CLK_HDMI>, > > + <&ccu CLK_PLL_VIDEO0_2X>, > > + <&ccu CLK_PLL_VIDEO1_2X>; > > + clock-names =3D "ahb", "mod", "pll-0", "pll-1"; > > + status =3D "disabled"; > > + > > + port { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + hdmi0_in_tcon0: endpoint@0 { > > + reg =3D <0>; > > + remote-endpoint =3D <&tcon0_out= _hdmi0>; > > + }; > > + }; > > + }; > > + > > pwm: pwm@01c20e00 { > > compatible =3D "allwinner,sun5i-a10s-pwm"; > > reg =3D <0x01c20e00 0xc>; > > @@ -129,3 +155,11 @@ > > > > &sram_a { > > }; > > + > > +&tcon0_out { > > + tcon0_out_hdmi0: endpoint@2 { > > + reg =3D <2>; > > + remote-endpoint =3D <&hdmi0_in_tcon0>; > > + allwinner,tcon-channel =3D <1>; > > + }; > > +}; > > diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi > > index f3b6e19244f9..3d009b2aa42a 100644 > > --- a/arch/arm/boot/dts/sun5i.dtsi > > +++ b/arch/arm/boot/dts/sun5i.dtsi > > @@ -273,6 +273,7 @@ > > tcon0_out_tve0: endpoint@1 { > > reg =3D <1>; > > remote-endpoint =3D <&t= ve0_in_tcon0>; > > + allwinner,tcon-channel = =3D <1>; >=20 > This looks like a separate patch, probably following the binding > change? I don't know, the binding says that without anything specified, reg would be used. I was assuming that we only needed it once we had the new endpoint to make it consistent, therefore it didn't need an extra patch. But I can definitely create one if you want. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --ikoiozqmyzngxi4v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYwTWVAAoJEBx+YmzsjxAgunUP/0D7KJGfoMuMy1+eEyshi+D9 c1RT+29VmIa3vEPDT0yvR50Rz246p+UbarifLf+d1m0rLLJ9KCLQt30/+ISCbuDz g34ZZyle0AKeCpUI+0bTpb09ARLEbE4ELpC3VVdqyfTfmDZmjUZyevf2mvMJwTiN bQMuiriZXS9/zU4RxPd4K0RElhapXws9nLZ/AUwYH0GRgmVWEPc4aTu34tHK4s+I bPat0bnkzoLHlkMmWbT7D4dBMNvxYLczAib8N9FFH1r65Mqw8qyhAjeJBvI5XdYl aL56tcUDX72zQHY9oDHk2pqLgtlIlldJvDeSLRELlLiCgSKi/lkyd35WCYrCwI/h EzPa5wcLlZ7NDOFUjABk4+5GYDLY0ig5bUwosbwCnxLgqbWwJq6HDkH1EevoYfpS JhPSZV88g79eELMTOIpFMTnpRkiebuEsMcgNf8jWJSq/BmflI1DXz1rfQkq6Fo8G BJB/4Qx/haXe9ZC8gMpmIQNYbEQW6Uc2+pclU3C137NGXfrDKC90IeZ+K4UXJbnE mhEj5f4fbsWIvZdLOA672nvQiA8VS3fyq74ZoHQznIUz1ssgDCuD4fGyVb++W7Ot RyupTgrDcmKw/uuD4PegQLJNj0exWNQWEIg/PvOcB5lK2ilaPTp4s7Injainzi4W Feoiw/eidxij4UXvNh33 =Q/Ir -----END PGP SIGNATURE----- --ikoiozqmyzngxi4v--