From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932161AbdCILHp (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Mar 2017 06:07:45 -0500
Received: from mail-wm0-f53.google.com ([74.125.82.53]:33310 "EHLO
        mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754588AbdCILHn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Mar 2017 06:07:43 -0500
Date: Thu, 9 Mar 2017 12:07:33 +0100
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: robh+dt@kernel.org, kishon@ti.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, mark.rutland@arm.com,
        sboyd@codeaurora.org, srinivas.kandagatla@linaro.org,
        Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v5 3/4] dt-bindings: phy: Add support for QMP phy
Message-ID: <20170309110733.GB53510@Bjorns-MacBook-Pro-2.local>
References: <1489050441-3240-1-git-send-email-vivek.gautam@codeaurora.org>
 <1489050441-3240-4-git-send-email-vivek.gautam@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1489050441-3240-4-git-send-email-vivek.gautam@codeaurora.org>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu 09 Mar 10:07 CET 2017, Vivek Gautam wrote:

[..]
> +	phy@34000 {
> +		compatible = "qcom,msm8996-qmp-pcie-phy";
> +		reg = <0x034000 0x488>;

Drop the leading 0 from the address.

> +		#clock-cells = <1>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		clocks = <&gcc GCC_PCIE_PHY_AUX_CLK>,
> +			<&gcc GCC_PCIE_PHY_CFG_AHB_CLK>,
> +			<&gcc GCC_PCIE_CLKREF_CLK>;
> +		clock-names = "aux", "cfg_ahb", "ref";
> +
> +		vdda-phy-supply = <&pm8994_l28>;
> +		vdda-pll-supply = <&pm8994_l12>;
> +
> +		resets = <&gcc GCC_PCIE_PHY_BCR>,
> +			<&gcc GCC_PCIE_PHY_COM_BCR>,
> +			<&gcc GCC_PCIE_PHY_COM_NOCSR_BCR>;
> +		reset-names = "phy", "common", "cfg";
> +
> +		pciephy_0: lane@0 {

The "@xyz" part should match the first value in "reg", i.e. 35000 here.

> +			reg = <0x035000 0x130>,
> +				<0x035200 0x200>,
> +				<0x035400 0x1dc>;
> +			#phy-cells = <0>;
> +
> +			clocks = <&gcc GCC_PCIE_0_PIPE_CLK>;
> +			clock-names = "pipe0";
> +			resets = <&gcc GCC_PCIE_0_PHY_BCR>;
> +			reset-names = "lane0";
> +		};
> +
> +		pciephy_1: lane@1 {
> +		...
> +		...
> +	};

Regards,
Bjorn