From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932374AbdCIMES (ORCPT ); Thu, 9 Mar 2017 07:04:18 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:38116 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932269AbdCIMEP (ORCPT ); Thu, 9 Mar 2017 07:04:15 -0500 Date: Thu, 9 Mar 2017 12:09:18 +0100 From: Mark Brown To: Brian Norris Cc: Liam Girdwood , linux-kernel@vger.kernel.org, Jaroslav Kysela , Kuninori Morimoto , Takashi Iwai , alsa-devel@alsa-project.org Message-ID: <20170309110918.getjla6iawgjpfrq@sirena.org.uk> References: <20170308231854.50167-1-briannorris@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bkcchgg6exn7kagu" Content-Disposition: inline In-Reply-To: <20170308231854.50167-1-briannorris@chromium.org> X-Cookie: A fool and his money are soon popular. User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 109.74.48.129 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bkcchgg6exn7kagu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 08, 2017 at 03:18:54PM -0800, Brian Norris wrote: > Not all platform drivers have pcm_{new,free} callbacks. Seen with a > "snd-soc-dummy" codec from sound/soc/rockchip/rk3399_gru_sound.c. >=20 > Resolves an OOPS seen on v4.11-rc1 with Google Kevin (Samsung Chromebook > Plus): >=20 > [ 2.863304] rk3399-gru-sound sound: HiFi <-> ff880000.i2s mapping ok > [ 2.886930] rk3399-gru-sound sound: rt5514-aif1 <-> ff880000.i2s mappi= ng ok Please think hard before including complete backtraces in upstream reports, they are very large and contain almost no useful information relative to their size so often obscure the relevant content in your message. If part of the backtrace is usefully illustrative then it's usually better to pull out the relevant sections. --bkcchgg6exn7kagu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljBN9sACgkQJNaLcl1U h9ASZgf+Oo3xEmolDL/GoyNXNPpy/URBLFC2tWwUeat7sfLMFIhuHrvu2acx39y3 tcYEB0WJVDiCYX2QT1fa8L99LoJWYj43mH4bptwZUfLBzHuScVXWoeQaBS/dsxtm wKs+mQZMDG4ieTSuwCqEGvfhf2E8KbOFlgu2RAUtSXNOa7rCpRHZdWQbJw9jG2pj MR7ZlKbrq7FuVtRjU40g1GtsBc1i49CYnB4zY4DXnMvLGQOXNEnf4UL7TifPB0FG 5zPwonRmqygP5QY6yc5nyoTJB2xKVtKihUb8TBfRWD6nzRclhfIkpsfRKbIG3TNo 5oYn5NU7Cq3epIX93iF5XKnz2L8D9A== =Q369 -----END PGP SIGNATURE----- --bkcchgg6exn7kagu--