From: Michal Hocko <mhocko@kernel.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
"K. Y. Srinivasan" <kys@microsoft.com>,
David Rientjes <rientjes@google.com>,
Daniel Kiper <daniel.kiper@oracle.com>,
linux-api@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-s390@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-acpi@vger.kernel.org, qiuxishi@huawei.com,
toshi.kani@hpe.com, xieyisheng1@huawei.com, slaoub@gmail.com,
iamjoonsoo.kim@lge.com, vbabka@suse.cz
Subject: Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks
Date: Thu, 9 Mar 2017 13:54:00 +0100 [thread overview]
Message-ID: <20170309125400.GI11592@dhcp22.suse.cz> (raw)
In-Reply-To: <20170307134004.58343e14@nial.brq.redhat.com>
On Tue 07-03-17 13:40:04, Igor Mammedov wrote:
> On Mon, 6 Mar 2017 15:54:17 +0100
> Michal Hocko <mhocko@kernel.org> wrote:
>
> > On Fri 03-03-17 18:34:22, Igor Mammedov wrote:
[...]
> > > in current mainline kernel it triggers following code path:
> > >
> > > online_pages()
> > > ...
> > > if (online_type == MMOP_ONLINE_KERNEL) {
> > > if (!zone_can_shift(pfn, nr_pages, ZONE_NORMAL, &zone_shift))
> > > return -EINVAL;
> >
> > Are you sure? I would expect MMOP_ONLINE_MOVABLE here
> pretty much, reproducer is above so try and see for yourself
I will play with this...
[...]
> > > get_maintainer.pl doesn't lists linux-api for 31bc3858ea3e,
> > > MAINTAINERS should be fixed if linux-api were to be CCed.
> >
> > user visible APIs _should_ be discussed at this mailing list regardless
> > what get_maintainer.pl says. This is not about who is the maintainer but
> > about getting as wide audience for things that would have to be
> > maintained basically for ever.
>
> How would random contributor know which list to CC?
This should have been brought up during the review process which was
less than sufficient in this case.
> > > > So unless this causes a major regression which would be hard to fix I
> > > > will submit the patch for inclusion.
> > > it will be a major regression due to lack of daemon that
> > > could online fast and can't be killed on OOM. So this
> > > clean up patch does break used feature without providing
> > > a viable alternative.
> >
> > So let's discuss the current memory hotplug shortcomings and get rid of
> > the crud which developed on top. I will start by splitting up the patch
> > into 3 parts. Do the auto online thing from the HyperV and xen balloning
> > drivers and dropping the config option and finally drop the sysfs knob.
> > The last patch might be NAKed and I can live with that as long as the
> > reasoning is proper and there is a general consensus on that.
> PS: CC me on that patches too
>
> It's major regression if you remove auto online in kernels that
> run on top of x86 kvm/vmware hypervisors, making API cleanups
> while breaking useful functionality doesn't make sense.
>
> I would ACK config option removal if auto online keeps working
> for all x86 hypervisors (hyperv/xen isn't the only who needs it)
> and keep kernel CLI option to override default.
>
> That doesn't mean that others will agree with flipping default,
> that's why config option has been added.
>
> Now to sum up what's been discussed on this thread, there were 2
> different issues discussed:
> 1) memory hotplug: remove in kernel auto online for all
> except of hyperv/xen
>
> - suggested RFC is not acceptable from virt point of view
> as it regresses guests on top of x86 kvm/vmware which
> both use ACPI based memory hotplug.
>
> - udev/userspace solution doesn't work in practice as it's
> too slow and unreliable when system is under load which
> is quite common in virt usecase. That's why auto online
> has been introduced in the first place.
Please try to be more specific why "too slow" is a problem. Also how
much slower are we talking about?
> 2) memory unplug: online memory as movable
>
> - doesn't work currently with udev rule due to kernel
> issues https://bugzilla.redhat.com/show_bug.cgi?id=1314306#c7
These should be fixed
> - could be fixed both for in kernel auto online and udev
> with following patch:
> https://bugzilla.redhat.com/attachment.cgi?id=1146332
> but fixing it this way exposes zone disbalance issues,
> which are not present in current kernel as blocks are
> onlined in Zone Normal. So this is area to work and
> improve on.
>
> - currently if one wants to use online_movable,
> one has to either
> * disable auto online in kernel OR
which might not just work because an unmovable allocation could have
made the memblock pinned.
> * remove udev rule that distro ships
> AND write custom daemon that will be able to online
> block in right zone/order. So currently whole
> online_movable thing isn't working by default
> regardless of who onlines memory.
my epxperience with onlining full nodes as movable shows this works just
fine (with all the limitations of the movable zones but that is a
separate thing). I haven't played with configurations where movable
zones are sharing the node with other zones.
> I'm in favor of implementing that in kernel as it keeps
> kernel internals inside kernel and doesn't need
> kernel API to be involved (memory blocks in sysfs,
> online_kernel, online_movable)
> There would be no need in userspace which would have to
> deal with kernel zoo and maintain that as well.
The kernel is supposed to provide a proper API and that is sysfs
currently. I am not entirely happy about it either but pulling a lot of
code into the kernel is not the rigth thing to do. Especially when
different usecases require different treatment.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-03-09 12:54 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 9:28 [RFC PATCH] mm, hotplug: get rid of auto_online_blocks Michal Hocko
2017-02-27 10:02 ` Vitaly Kuznetsov
2017-02-27 10:21 ` Michal Hocko
2017-02-27 10:49 ` Vitaly Kuznetsov
2017-02-27 12:56 ` Michal Hocko
2017-02-27 13:17 ` Vitaly Kuznetsov
2017-02-27 11:25 ` Heiko Carstens
2017-02-27 11:50 ` Vitaly Kuznetsov
2017-02-27 15:43 ` Michal Hocko
2017-02-28 10:21 ` Heiko Carstens
2017-03-02 13:53 ` Igor Mammedov
2017-03-02 14:28 ` Michal Hocko
2017-03-02 17:03 ` Igor Mammedov
2017-03-03 8:27 ` Michal Hocko
2017-03-03 17:34 ` Igor Mammedov
2017-03-06 14:54 ` Michal Hocko
2017-03-07 12:40 ` Igor Mammedov
2017-03-09 12:54 ` Michal Hocko [this message]
2017-03-10 13:58 ` WTH is going on with memory hotplug sysf interface (was: Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks) Michal Hocko
2017-03-10 15:53 ` Michal Hocko
2017-03-10 19:00 ` Reza Arbab
2017-03-13 9:21 ` Michal Hocko
2017-03-13 14:58 ` Reza Arbab
2017-03-14 19:35 ` Andrea Arcangeli
2017-03-15 7:57 ` Michal Hocko
2017-03-13 15:11 ` Michal Hocko
2017-03-13 23:16 ` Andi Kleen
2017-03-10 17:39 ` WTH is going on with memory hotplug sysf interface Yasuaki Ishimatsu
2017-03-13 9:19 ` Michal Hocko
2017-03-14 16:05 ` YASUAKI ISHIMATSU
2017-03-14 16:20 ` Michal Hocko
2017-03-13 10:31 ` WTH is going on with memory hotplug sysf interface (was: Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks) Igor Mammedov
2017-03-13 10:43 ` Michal Hocko
2017-03-13 13:57 ` Igor Mammedov
2017-03-13 14:36 ` Michal Hocko
2017-03-13 10:55 ` [RFC PATCH] mm, hotplug: get rid of auto_online_blocks Igor Mammedov
2017-03-13 12:28 ` Michal Hocko
2017-03-13 12:54 ` Vitaly Kuznetsov
2017-03-13 13:19 ` Michal Hocko
2017-03-13 13:42 ` Vitaly Kuznetsov
2017-03-13 14:32 ` Michal Hocko
2017-03-13 15:10 ` Vitaly Kuznetsov
2017-03-14 13:20 ` Igor Mammedov
2017-03-15 7:53 ` Michal Hocko
2017-03-10 22:00 ` Daniel Kiper
2017-02-27 17:28 ` Reza Arbab
2017-02-27 17:34 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309125400.GI11592@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=daniel.kiper@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=imammedo@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=qiuxishi@huawei.com \
--cc=rientjes@google.com \
--cc=slaoub@gmail.com \
--cc=toshi.kani@hpe.com \
--cc=vbabka@suse.cz \
--cc=vkuznets@redhat.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).