From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 03/13] perf, tools, stat: Handle partially bad results with merging
Date: Fri, 10 Mar 2017 13:24:36 -0800 [thread overview]
Message-ID: <20170310212446.6662-4-andi@firstfloor.org> (raw)
In-Reply-To: <20170310212446.6662-1-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
When any result that is being merged is bad, mark them all
bad to give consistent output in interval mode.
No before/after, because the issue was only found in theoretical
review and it is hard to reproduce
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/builtin-stat.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 0fd35be5520a..317024332bbd 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1237,6 +1237,16 @@ static void aggr_cb(struct perf_evsel *counter, void *data, bool first)
if (first)
ad->nr++;
counts = perf_counts(counter->counts, cpu, 0);
+ /*
+ * When any result is bad, make them all to give
+ * consistent output in interval mode.
+ */
+ if (counts->ena == 0 || counts->run == 0 ||
+ counter->counts->scaled == -1) {
+ ad->ena = 0;
+ ad->run = 0;
+ break;
+ }
ad->val += counts->val;
ad->ena += counts->ena;
ad->run += counts->run;
--
2.9.3
next prev parent reply other threads:[~2017-03-10 21:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 21:24 perf: Improve support for uncore JSON event lists Andi Kleen
2017-03-10 21:24 ` [PATCH 01/13] perf, tools, stat: Factor out callback for collecting event values Andi Kleen
2017-03-14 14:56 ` Jiri Olsa
2017-03-10 21:24 ` [PATCH 02/13] perf, tools, stat: Collapse identically named events Andi Kleen
2017-03-10 21:24 ` Andi Kleen [this message]
2017-03-10 21:24 ` [PATCH 04/13] perf, tools: Factor out PMU matching in parser Andi Kleen
2017-03-10 21:24 ` [PATCH 05/13] perf, tools: Expand PMU events by prefix match Andi Kleen
2017-03-10 21:24 ` [PATCH 06/13] perf, tools: Special case uncore_ prefix Andi Kleen
2017-03-10 21:24 ` [PATCH 07/13] perf, tools: Add a simple expression parser for JSON Andi Kleen
2017-03-10 21:24 ` [PATCH 08/13] perf, tools: Update Intel uncore JSON event files Andi Kleen
2017-03-10 21:24 ` [PATCH 09/13] perf, tools: Support MetricExpr header in JSON event list Andi Kleen
2017-03-10 21:24 ` [PATCH 10/13] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen
2017-03-10 21:24 ` [PATCH 11/13] perf, tools, list: Support printing MetricExpr with --debug Andi Kleen
2017-03-10 21:24 ` [PATCH 12/13] perf, tools: Add support for MetricName JSON attribute Andi Kleen
2017-03-10 21:24 ` [PATCH 13/13] perf, tools, list: Move extra details printing to new option Andi Kleen
2017-03-13 14:43 ` perf: Improve support for uncore JSON event lists Jiri Olsa
2017-03-13 16:11 ` Andi Kleen
2017-03-13 16:15 ` Jiri Olsa
2017-03-20 20:16 Andi Kleen
2017-03-20 20:17 ` [PATCH 03/13] perf, tools, stat: Handle partially bad results with merging Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310212446.6662-4-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).