From: Stephen Boyd <sboyd@codeaurora.org>
To: Markus Mayer <code@mmayer.net>
Cc: Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mike Turquette <mturquette@linaro.org>,
Linux Clock Mailing List <linux-clk@vger.kernel.org>,
Device Tree Mailing List <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Markus Mayer <mmayer@broadcom.com>
Subject: Re: [RFC 1/2] clk: dt: binding for basic divider clock
Date: Tue, 14 Mar 2017 18:07:10 -0700 [thread overview]
Message-ID: <20170315010710.GJ10239@codeaurora.org> (raw)
In-Reply-To: <20170314202236.39910-2-code@mmayer.net>
On 03/14, Markus Mayer wrote:
> From: Mike Turquette <mturquette@linaro.org>
>
> Devicetree binding for the basic clock divider, plus the setup function
> to register the clock. Based on the existing fixed-clock binding.
>
> Tero Kristo contributed helpful bug fixes to this patch.
>
> Signed-off-by: Mike Turquette <mturquette@linaro.org>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
These sorts of details should go into C code. Is there any
difficulty in writing a driver to do so? So far we've avoided
adding the generic divider, multiplier, mux, bindings because
those usually need some register level details that we've been
reluctant to add to DT.
That's because if something is wrong with these register level
details or we need to make some policy updates, e.g. favor this
divider over another, we can't really do that with a DT update.
So we really want to see DT nodes have some hardware specific
compatible string, and also put the logic for the driver into the
code so that it can be easily fixed and updated after the fact.
The DTS file is there to tell us "I have a divider from company X
here and it's connected to this and that" and the driver is there
to do the work of driving that piece of hardware so it works
properly.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-03-15 1:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 20:22 [RFC 0/2] Basic divider clock Markus Mayer
2017-03-14 20:22 ` [RFC 1/2] clk: dt: binding for basic " Markus Mayer
2017-03-15 1:07 ` Stephen Boyd [this message]
2017-03-14 20:22 ` [RFC 2/2] clk: divider: modifications for 4.11 Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315010710.GJ10239@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=code@mmayer.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mmayer@broadcom.com \
--cc=mturquette@baylibre.com \
--cc=mturquette@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).