From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752725AbdCONSI (ORCPT ); Wed, 15 Mar 2017 09:18:08 -0400 Received: from mail.kernel.org ([198.145.29.136]:35318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbdCONRF (ORCPT ); Wed, 15 Mar 2017 09:17:05 -0400 Date: Wed, 15 Mar 2017 10:16:57 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Ravi Bangoria , mingo@redhat.com, mhiramat@kernel.org, brendan.d.gregg@gmail.com, peterz@infradead.org, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, jolsa@kernel.org, ak@linux.intel.com, treeze.taeung@gmail.com, mathieu.poirier@linaro.org, hekuang@huawei.com, sukadev@linux.vnet.ibm.com, ananth@in.ibm.com, naveen.n.rao@linux.vnet.ibm.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com Subject: Re: [PATCH v5 3/7] perf/sdt: Directly record SDT events with 'perf record' Message-ID: <20170315131657.GI12825@kernel.org> References: <20170314150658.7065-1-ravi.bangoria@linux.vnet.ibm.com> <20170314150658.7065-4-ravi.bangoria@linux.vnet.ibm.com> <20170315120331.GC18147@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170315120331.GC18147@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Mar 15, 2017 at 01:03:31PM +0100, Jiri Olsa escreveu: > On Tue, Mar 14, 2017 at 08:36:54PM +0530, Ravi Bangoria wrote: > > +++ b/tools/perf/builtin-record.c > > +static int record__parse_events_option(const struct option *opt, > > + const char *str, > > + int unset) > > +{ > > + if (is_sdt_event((char *) str)) > > + return parse_sdt_events_option(opt, str, unset); > > + else > > + return parse_events_option(opt, str, unset); > > so what happens if there're more than one event in 'str' like: > -e cycles,std_... > > would it be better to plug this directly into parse-events.y > parser.. and handle it like any other event type? Yeah, I went to bed thinking about this :-) Ravi, Please test something like: perf record -e cycles,sdt_glib:mem__alloc,sched:*switch -a sleep 5s - Arnaldo - Arnaldo