From: Patrick Bellasi <patrick.bellasi@arm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Juri Lelli <juri.lelli@arm.com>, Todd Kjos <tkjos@android.com>,
Tim Murray <timmurray@google.com>,
Andres Oportus <andresoportus@google.com>,
Joel Fernandes <joelaf@google.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Chris Redpath <chris.redpath@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections
Date: Wed, 15 Mar 2017 18:02:51 +0000 [thread overview]
Message-ID: <20170315180251.GI18557@e110439-lin> (raw)
In-Reply-To: <20170306093541.0cb8d4d3@gandalf.local.home>
On 06-Mar 09:35, Steven Rostedt wrote:
> On Thu, 2 Mar 2017 15:45:03 +0000
> Patrick Bellasi <patrick.bellasi@arm.com> wrote:
>
> > @@ -287,6 +289,10 @@ static void sugov_update_shared(struct update_util_data *hook, u64 time,
> > goto done;
> > }
> >
> > + /* Skip updates generated by sugov kthreads */
> > + if (curr == sg_policy->thread)
>
> I think you want to put in an "unlikely()" around that statement. I'm
> assuming you don't care about he performance of scheduling in the sugov
> thread. At least tell gcc to optimize for the false path.
Right, good point! Will add it in the next posting! +1
Thanks!
--
#include <best/regards.h>
Patrick Bellasi
next prev parent reply other threads:[~2017-03-15 18:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 15:45 [PATCH 0/6] cpufreq: schedutil: fixes for flags updates Patrick Bellasi
2017-03-02 15:45 ` [PATCH 1/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter Patrick Bellasi
2017-03-03 3:41 ` Viresh Kumar
2017-03-06 14:29 ` Steven Rostedt
2017-03-15 18:06 ` Patrick Bellasi
2017-03-28 22:18 ` Rafael J. Wysocki
2017-04-07 14:59 ` Patrick Bellasi
2017-06-06 9:26 ` Viresh Kumar
2017-06-06 15:56 ` Rafael J. Wysocki
2017-06-06 18:03 ` Patrick Bellasi
2017-03-02 15:45 ` [PATCH 2/6] cpufreq: schedutil: ignore the sugov kthread for frequencies selections Patrick Bellasi
2017-03-03 5:19 ` Viresh Kumar
2017-03-03 12:12 ` Patrick Bellasi
2017-03-06 5:08 ` Viresh Kumar
2017-03-06 14:35 ` Steven Rostedt
2017-03-15 18:02 ` Patrick Bellasi [this message]
2017-03-02 15:45 ` [PATCH 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks Patrick Bellasi
2017-03-03 8:31 ` Viresh Kumar
2017-03-03 12:38 ` Patrick Bellasi
2017-03-15 11:52 ` Rafael J. Wysocki
2017-03-15 14:40 ` Patrick Bellasi
2017-03-15 23:32 ` Rafael J. Wysocki
2017-03-17 11:36 ` Patrick Bellasi
2017-04-07 15:30 ` Peter Zijlstra
2017-04-07 16:59 ` Patrick Bellasi
2017-03-02 15:45 ` [PATCH 4/6] cpufreq: schedutil: relax rate-limiting " Patrick Bellasi
2017-03-02 15:45 ` [PATCH 5/6] cpufreq: schedutil: avoid utilisation update when not necessary Patrick Bellasi
2017-03-02 15:45 ` [PATCH 6/6] sched/rt: fast switch to maximum frequency when RT tasks are scheduled Patrick Bellasi
2017-03-02 16:09 ` [PATCH 0/6] cpufreq: schedutil: fixes for flags updates Vincent Guittot
2017-03-02 17:11 ` Patrick Bellasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315180251.GI18557@e110439-lin \
--to=patrick.bellasi@arm.com \
--cc=andresoportus@google.com \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=john.stultz@linaro.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rostedt@goodmis.org \
--cc=timmurray@google.com \
--cc=tkjos@android.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).