From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751279AbdCPC3l (ORCPT ); Wed, 15 Mar 2017 22:29:41 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:46257 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751170AbdCPC3j (ORCPT ); Wed, 15 Mar 2017 22:29:39 -0400 Date: Thu, 16 Mar 2017 10:24:17 +0800 From: Jisheng Zhang To: Ziji Hu CC: Ulf Hansson , Gregory CLEMENT , Adrian Hunter , "linux-mmc@vger.kernel.org" , Jason Cooper , "Andrew Lunn" , Sebastian Hesselbarth , Thomas Petazzoni , "linux-arm-kernel@lists.infradead.org" , Mike Turquette , Stephen Boyd , linux-clk , "linux-kernel@vger.kernel.org" , Rob Herring , "devicetree@vger.kernel.org" , Jimmy Xu , Nadav Haklai , Ryan Gao , Doug Jones , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , Yehuda Yitschak , Marcin Wojtas , Hanna Hawa , Kostya Porotchkin Subject: Re: [PATCH v6 08/14] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality Message-ID: <20170316102417.0909bccc@xhacker> In-Reply-To: <10855817-e693-e007-9499-c4e97936fadb@marvell.com> References: <10855817-e693-e007-9499-c4e97936fadb@marvell.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-16_01:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703160017 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ziji On Wed, 15 Mar 2017 21:58:43 +0800 Ziji Hu wrote: > Hi Ulf, > > On 2017/3/15 21:11, Ulf Hansson wrote: > > On 14 February 2017 at 18:01, Gregory CLEMENT > > wrote: > >> From: Hu Ziji > > >> +config MMC_SDHCI_XENON > >> + tristate "Marvell Xenon eMMC/SD/SDIO SDHCI driver" > >> + depends on MMC_SDHCI_PLTFM > >> + help > >> + This selects Marvell Xenon eMMC/SD/SDIO SDHCI. > >> + If you have a machine with integrated Marvell Xenon SDHC IP, > > > > /s/SDHC/SDHCI > > > > Sorry. I don't get your point. > Could you please give more detailed comments? Ulf want you to s/SDHC/SDHCI in the line "If you have .....", I.E change the line to: If you have a machine with integrated Marvell Xenon SDHCI IP, Thanks, Jisheng