From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Potapenko <glider@google.com>
Cc: Michael Davidson <md@google.com>, Michal Marek <mmarek@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Shaohua Li <shli@kernel.org>, Dmitry Vyukov <dvyukov@google.com>,
Matthias Kaehlcke <mka@chromium.org>,
x86@kernel.org, linux-kbuild@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, linux-raid@vger.kernel.org
Subject: Re: [PATCH 6/7] md/raid10, LLVM: get rid of variable length array
Date: Fri, 17 Mar 2017 13:44:04 +0100 [thread overview]
Message-ID: <20170317124404.mt3jd5q5vyk63q2w@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAG_fn=XcQLtcHRSm2BHYce9LMtyFJ+fWxfE4vYPCw+7U0DcrmQ@mail.gmail.com>
On Fri, Mar 17, 2017 at 01:31:23PM +0100, Alexander Potapenko wrote:
> On Fri, Mar 17, 2017 at 1:08 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Thu, Mar 16, 2017 at 05:15:19PM -0700, Michael Davidson wrote:
> >> Replace a variable length array in a struct by allocating
> >> the memory for the entire struct in a char array on the stack.
> >>
> >> Signed-off-by: Michael Davidson <md@google.com>
> >> ---
> >> drivers/md/raid10.c | 9 ++++-----
> >> 1 file changed, 4 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> >> index 063c43d83b72..158ebdff782c 100644
> >> --- a/drivers/md/raid10.c
> >> +++ b/drivers/md/raid10.c
> >> @@ -4654,11 +4654,10 @@ static int handle_reshape_read_error(struct mddev *mddev,
> >> /* Use sync reads to get the blocks from somewhere else */
> >> int sectors = r10_bio->sectors;
> >> struct r10conf *conf = mddev->private;
> >> - struct {
> >> - struct r10bio r10_bio;
> >> - struct r10dev devs[conf->copies];
> >> - } on_stack;
> >> - struct r10bio *r10b = &on_stack.r10_bio;
> >> + char on_stack_r10_bio[sizeof(struct r10bio) +
> >> + conf->copies * sizeof(struct r10dev)]
> >> + __aligned(__alignof__(struct r10bio));
> >> + struct r10bio *r10b = (struct r10bio *)on_stack_r10_bio;
> >> int slot = 0;
> >> int idx = 0;
> >> struct bio_vec *bvec = r10_bio->master_bio->bi_io_vec;
> >
> >
> > That's disgusting. Why not fix LLVM to support this?
>
> IIUC there's only a handful of VLAIS instances in LLVM code, why not
> just drop them for the sake of better code portability?
> (To quote Linus, "this feature is an abomination":
> https://lkml.org/lkml/2013/9/23/500)
Be that as it may; what you construct above is disgusting. Surely the
code can be refactored to not look like dog vomit?
Also; its not immediately obvious conf->copies is 'small' and this
doesn't blow up the stack; I feel that deserves a comment somewhere.
next prev parent reply other threads:[~2017-03-17 12:44 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 0:15 [PATCH 0/7] LLVM: make x86_64 kernel build with clang Michael Davidson
2017-03-17 0:15 ` [PATCH 1/7] Makefile, LLVM: add -no-integrated-as to KBUILD_[AC]FLAGS Michael Davidson
2017-04-03 22:49 ` Matthias Kaehlcke
2017-04-21 7:49 ` Masahiro Yamada
2017-03-17 0:15 ` [PATCH 2/7] Makefile, x86, LLVM: disable unsupported optimization flags Michael Davidson
2017-03-17 21:32 ` H. Peter Anvin
2017-03-17 21:34 ` H. Peter Anvin
2017-04-05 18:08 ` Masahiro Yamada
2017-04-05 19:01 ` Matthias Kaehlcke
2017-04-05 19:11 ` Michael Davidson
2017-04-10 14:54 ` Masahiro Yamada
2017-03-17 0:15 ` [PATCH 3/7] x86, LLVM: suppress clang warnings about unaligned accesses Michael Davidson
2017-03-17 23:50 ` hpa
2017-04-03 23:01 ` Matthias Kaehlcke
2017-04-13 23:14 ` Matthias Kaehlcke
2017-04-13 23:55 ` H. Peter Anvin
2017-04-14 0:23 ` Matthias Kaehlcke
2017-04-14 5:30 ` hpa
2017-03-17 0:15 ` [PATCH 4/7] x86, boot, LLVM: #undef memcpy etc in string.c Michael Davidson
2017-06-22 22:31 ` Matthias Kaehlcke
2017-06-22 22:37 ` H. Peter Anvin
2017-06-30 18:32 ` Matthias Kaehlcke
2017-03-17 0:15 ` [PATCH 5/7] x86, boot, LLVM: Use regparm=0 for memcpy and memset Michael Davidson
2017-03-17 12:08 ` Peter Zijlstra
2017-06-22 22:38 ` H. Peter Anvin
2017-03-17 0:15 ` [PATCH 6/7] md/raid10, LLVM: get rid of variable length array Michael Davidson
2017-03-17 12:08 ` Peter Zijlstra
2017-03-17 12:31 ` Alexander Potapenko
2017-03-17 12:32 ` Alexander Potapenko
2017-03-17 18:03 ` Borislav Petkov
2017-03-17 18:47 ` Dmitry Vyukov
2017-03-17 18:57 ` Borislav Petkov
2017-03-17 19:05 ` Dmitry Vyukov
2017-03-17 19:26 ` Peter Zijlstra
2017-03-17 19:29 ` Peter Zijlstra
2017-03-24 13:50 ` Dmitry Vyukov
2017-03-24 14:10 ` Peter Zijlstra
2017-03-24 14:22 ` Dmitry Vyukov
2017-03-18 0:41 ` Fengguang Wu
2017-03-17 12:44 ` Peter Zijlstra [this message]
2017-03-17 18:52 ` Michael Davidson
2017-03-17 19:27 ` Peter Zijlstra
2017-03-17 20:04 ` hpa
2017-03-24 13:47 ` Dmitry Vyukov
2017-03-24 14:09 ` Peter Zijlstra
2017-03-17 0:15 ` [PATCH 7/7] crypto, x86, LLVM: aesni - fix token pasting Michael Davidson
2017-04-03 23:14 ` Matthias Kaehlcke
2017-03-17 8:17 ` [PATCH 0/7] LLVM: make x86_64 kernel build with clang Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317124404.mt3jd5q5vyk63q2w@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=md@google.com \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=mmarek@suse.com \
--cc=shli@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).