From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbdCTJSy (ORCPT ); Mon, 20 Mar 2017 05:18:54 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:54568 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966AbdCTJSw (ORCPT ); Mon, 20 Mar 2017 05:18:52 -0400 From: Arnd Bergmann To: Peter Huewe , Marcel Selhorst , Jarkko Sakkinen Cc: Arnd Bergmann , Jason Gunthorpe , "Winkler, Tomas" , Jerry Snitselaar , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused Date: Mon, 20 Mar 2017 10:17:19 +0100 Message-Id: <20170320091755.1043811-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:R5TtVjZRRZhN3dKFL+AYj+yFwmTEa2IosgiV6lRpweb3+gcWbEL WrAU3ShNwtZypTXIXDF2kuklpGA7aV0rED47u9LmTofnZKeR/IqvVQC0eH4tKhi6553aX/W LJezyWJ9CEWVPPS97fbKekIEKonIRm2a9nnSVr13VjyGO2XTEeqLI1PruQw9O/fb7Mmm4TO nk/2KBsAxK2V1v7YaCI/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:RxrvfhWpWjg=:exM9rsXCtL4gOA1Rm5q9w2 /rMRsp0w/J4UKOcwGAO2SXg6Vg6ghyKKjnnI0ExVUjtWSzNO3SIQlAq3WMFfSdb09tl2MqkHT lAB1xk244nh1YlbxFhhHKs7KlI8zO2gPEeVUrDzKZo1oFnR4MNJtD1gGtuutwR6rDsumXbXjK e7J5xxXDYw7r/HcFm802IRRnIO1tGK9/Hm+V0R4TaUPrJFM9FK+Zkb/vrjedEJPE7yYGZGk7o cO58blX0W6ahtAowj7oX+2poXX+qofYaQQMvTEUeQ6H5hrEQookrwEfJp6MKdpnkzdB2fsKkW H9f55b21jVeZZd3t0MkyQFXZw5zCNZYHou8h6pR0QMML6cuI2jdUTlYKwxXZRYluy08qyFAWF +yTQ9rUllLna1/GCLuUjHXmdh0+8cRnijE+9Vnd8YHP8fhybqdn+9Qzj4T3Mx0ZDmn4pjxpEd KaPeVbq2eS+7K3bTqk/AxRLCc18GzJQ9FbyHQtoWNPQRW99AodZ/0eCB1AiQWwYKYrXC2DUY4 J4bPwegcxxGh8F6Uke2tARMDeBMiX7hGL2FkIa+Wl+ZsMaBXJLHHfGGXoJFtf0Te58bgkPWzR dAFOqOXeM54RHVGQ9yIlnCWhsk6B1gCF6vJBvDUx1IaEkcSwb7J1VMh0SWepLs810wkpAdY4f MHgdgYk+LFLrWhnITppGic86t8DAO3T1E82PIZkEf8LYu/o6qEguurnp2OdpXKuJcb2s= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_PM_SLEEP is disabled, we get a warning about unused functions: drivers/char/tpm/tpm_crb.c:551:12: error: 'crb_pm_resume' defined but not used [-Werror=unused-function] drivers/char/tpm/tpm_crb.c:540:12: error: 'crb_pm_suspend' defined but not used [-Werror=unused-function] We could solve this with more sophistated #ifdefs, but a simpler and safer way is to just mark them as __maybe_unused. Fixes: 848efcfb560c ("tpm/tpm_crb: enter the low power state upon device suspend") Signed-off-by: Arnd Bergmann --- drivers/char/tpm/tpm_crb.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c index 1dfc37e33c02..15f1118982a6 100644 --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -519,8 +519,7 @@ static int crb_acpi_remove(struct acpi_device *device) return 0; } -#ifdef CONFIG_PM -static int crb_pm_runtime_suspend(struct device *dev) +static __maybe_unused int crb_pm_runtime_suspend(struct device *dev) { struct tpm_chip *chip = dev_get_drvdata(dev); struct crb_priv *priv = dev_get_drvdata(&chip->dev); @@ -528,7 +527,7 @@ static int crb_pm_runtime_suspend(struct device *dev) return crb_go_idle(dev, priv); } -static int crb_pm_runtime_resume(struct device *dev) +static __maybe_unused int crb_pm_runtime_resume(struct device *dev) { struct tpm_chip *chip = dev_get_drvdata(dev); struct crb_priv *priv = dev_get_drvdata(&chip->dev); @@ -536,7 +535,7 @@ static int crb_pm_runtime_resume(struct device *dev) return crb_cmd_ready(dev, priv); } -static int crb_pm_suspend(struct device *dev) +static __maybe_unused int crb_pm_suspend(struct device *dev) { int ret; @@ -547,7 +546,7 @@ static int crb_pm_suspend(struct device *dev) return crb_pm_runtime_suspend(dev); } -static int crb_pm_resume(struct device *dev) +static __maybe_unused int crb_pm_resume(struct device *dev) { int ret; @@ -558,8 +557,6 @@ static int crb_pm_resume(struct device *dev) return tpm_pm_resume(dev); } -#endif /* CONFIG_PM */ - static const struct dev_pm_ops crb_pm = { SET_SYSTEM_SLEEP_PM_OPS(crb_pm_suspend, crb_pm_resume) SET_RUNTIME_PM_OPS(crb_pm_runtime_suspend, crb_pm_runtime_resume, NULL) -- 2.9.0