From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754296AbdCTKpb (ORCPT ); Mon, 20 Mar 2017 06:45:31 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35540 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754180AbdCTKo3 (ORCPT ); Mon, 20 Mar 2017 06:44:29 -0400 Date: Mon, 20 Mar 2017 10:44:16 +0000 From: Lee Jones To: Quentin Schulz Cc: sre@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, maxime.ripard@free-electrons.com, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, icenowy@aosc.xyz, liam@networkimprov.net, thomas.petazzoni@free-electrons.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [RESEND PATCH v4 9/9] mfd: axp20x: add CHRG_CTRL1/2/3 to writeable regs for AXP20X/AXP22X Message-ID: <20170320104416.ph2wbvsie5tj53up@dell> References: <20170320081653.8884-1-quentin.schulz@free-electrons.com> <20170320081653.8884-10-quentin.schulz@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170320081653.8884-10-quentin.schulz@free-electrons.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Mar 2017, Quentin Schulz wrote: > The CHRG_CTRL1 and CHRG_CTRL2 registers are made for controlling > different battery charging settings such as the constant current charge > value. > > The AXP22X also have a third register CHRG_CTRL3 which has settings for > battery charging too. > > This adds the CHRG_CTRL1, CHRG_CTRL2 and CHRG_CTRL3 registers to the > list of writeable registers for AXP20X and AXP22X PMICs. > > Signed-off-by: Quentin Schulz > Acked-by: Maxime Ripard > Acked-by: Chen-Yu Tsai > Acked-for-MFD-by: Lee Jones > --- > > v2: > - added AXP20X_CHRG_CTRL2 and AXP20X_CHRG_CTRL3 to the writeable > registers table, > - removed added reg range for ADC data in volatile regs range, > > drivers/mfd/axp20x.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 37643b1..5ba3b04 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -68,6 +68,7 @@ static const struct regmap_access_table axp152_volatile_table = { > > static const struct regmap_range axp20x_writeable_ranges[] = { > regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), > + regmap_reg_range(AXP20X_CHRG_CTRL1, AXP20X_CHRG_CTRL2), > regmap_reg_range(AXP20X_DCDC_MODE, AXP20X_FG_RES), > regmap_reg_range(AXP20X_RDC_H, AXP20X_OCV(AXP20X_OCV_MAX)), > }; > @@ -94,6 +95,7 @@ static const struct regmap_access_table axp20x_volatile_table = { > /* AXP22x ranges are shared with the AXP809, as they cover the same range */ > static const struct regmap_range axp22x_writeable_ranges[] = { > regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), > + regmap_reg_range(AXP20X_CHRG_CTRL1, AXP22X_CHRG_CTRL3), > regmap_reg_range(AXP20X_DCDC_MODE, AXP22X_BATLOW_THRES1), > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog