From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753831AbdCTXFM (ORCPT ); Mon, 20 Mar 2017 19:05:12 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:34462 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218AbdCTXFL (ORCPT ); Mon, 20 Mar 2017 19:05:11 -0400 Date: Mon, 20 Mar 2017 17:04:30 -0600 From: Jason Gunthorpe To: "Winkler, Tomas" Cc: Arnd Bergmann , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Jerry Snitselaar , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused Message-ID: <20170320230430.GA25163@obsidianresearch.com> References: <20170320091755.1043811-1-arnd@arndb.de> <5B8DA87D05A7694D9FA63FD143655C1B543B032E@hasmsx108.ger.corp.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B543B0620@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B543B0620@hasmsx108.ger.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 20, 2017 at 11:01:36PM +0000, Winkler, Tomas wrote: > I believe that in this case the #ifdefs can be done correctly quite > easily, but now I'm not against your solution as well, just maybe > put some of this info to the commit message. I perfer fewer ifdefs, it makes it more maintainable.. The compiler will remove unused static functions. Jason