From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756757AbdCUKvr convert rfc822-to-8bit (ORCPT ); Tue, 21 Mar 2017 06:51:47 -0400 Received: from mout.gmx.net ([212.227.15.15]:61434 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755420AbdCUKvp (ORCPT ); Tue, 21 Mar 2017 06:51:45 -0400 From: Peter =?windows-1252?q?H=FCwe?= To: Guenter Roeck Subject: Re: Conversion of w83627ehf to hwmon_device_register_with_info ? Date: Tue, 21 Mar 2017 11:46:24 +0100 User-Agent: KMail/1.13.7 (Linux/4.10.1; KDE/4.14.24; x86_64; ; ) Cc: linux-hwmon@vger.kernel.org, Jean Delvare , linux-kernel@vger.kernel.org References: <201703030133.01363.PeterHuewe@gmx.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="windows-1252" Content-Transfer-Encoding: 8BIT Message-Id: <201703211146.24674.PeterHuewe@gmx.de> X-Provags-ID: V03:K0:FAQPHpSaVJ9Cf+btxR3NNn4+d2AFM2kNWGlJmwx2wH6ncwDYiXU X/JFSbSusx9TaTdjOjt7n9Vfe0dhXCQg2mJHmnvpzws/GjE5DDvihu2dfzVfOh2ZKGR7OpP xcK/GBkHaw9LHFgmlrMCLdb53NiHR6drg9tSnZQ5kIvhJ/IroHEdBR/SFb1+tbY+E9Kw21C MUdOxTrqIaUxp5diJNMWg== X-UI-Out-Filterresults: notjunk:1;V01:K0:fZkSYQeDN3o=:rbSpDXbxNFBHtTzgHam9Uk nTXDJ6v1/larCnOKNqSk1J8wudVmCzuRTavVwEy0UAV4e0LdDXXDeBeg3gXcqJKI5DKot+4HP FCcMW/BLk3b2je0+Yfm8aRnk5Cm+7WkogtWOHftlpkHXLLW3fzgt/DlvTWuUX6nDDjd7rSCPf kBdLUCwTwyUUUo/FP8M+f1Mn1GJA/TQuLJkQbacMLYGF5wYFoCMm2Z801Dn48aRfv5KhBe707 Bz+1tHOeIwigpSXFwH046I9vnYXQWU9UaicNZB9sx7EpfwHuzvsbq2oM/biycA6Qsj0mSneyI srNu6WFLBt37GFAjYZ6kdSPdSp0rBQilsudndiuwaEv9dD7wpXXb2jhSocKY4ZVjSrXyqG6sh r1FuzJ9Vnp45c1Xfnu/3OVKnlPtD0pS34aHK6hV0mYDlcyAtNCyNCRFMZj+/qbdFzmblTUDGR /rT11Da337Q1KEdrDSV36rzQ/DM/AE7uIEtpHB0sffUwZRo0IhAc0skFFn1kvpmfhfIZQHtnT fGUt/mY0w/SM5OFGUzuAcQJ1XWSvYDZNaA8CJmm08cNytWAgXb6stRExxSfa6Okkmuw7aw86U 6tVreLm1moBwnitLwDbKme+XDsl/Q+wnN8Rt40kvk13MzxQLHpRiOrfstC7zOaL+cPFkTy6TL R/7V/T+165j7xie5pnNOdpQggzNOZ43gWWES4fa6GvngdaFW8HvieH9PLl3wruuWeKzKEXNfF GNibi7FJZ1PYQN/IdyifPTcVPUt7SRhnENr2Vqb9iWitBwIa1x5zbtvYIPyKvsZkVSm0rk6wX vD5EIOE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On Friday 03 March 2017 03:56:01 Guenter Roeck wrote: > Hi Peter, > > On 03/02/2017 04:33 PM, Peter Hüwe wrote: > > Hi, > > > > is anybody else working on the conversion of the w83627ehf to the new > > hwmon_device_register_with_info interface? > > I don't think so. > > > Otherwise I will probably update the driver to this interface within the > > next days - but since it's a lot of work I wanted to check for > > duplication first. > > Go ahead. So I'm close to have to conversion done, the current diff stat is about 647 insertions(+), 787 deletions(-) for the whole conversion. Should I try to break it down into smaller chunks for easier review? Although this would mean to convert stuff from A to B and then from B to C - otherwise the intermediate steps would be not fully functional. (since the sysfs nodes partially would exist under hwmon1/ and partially under hwmon1/device/ (as they currently are)). or just submit it? It saves about 20k in compiled size, so the savings from reduced boilerplate are huge. (and I think it's more readable) > I would suggest to drop nct6775/nct6776 support to simplify the > code when you do that. Maybe as separate commit, though. Hehe - I'm testing on a nct6776 :) I'll look into it once the first conversion has been accepted. Thanks, Peter