From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757824AbdCUOLj (ORCPT ); Tue, 21 Mar 2017 10:11:39 -0400 Received: from foss.arm.com ([217.140.101.70]:53162 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757303AbdCUOLi (ORCPT ); Tue, 21 Mar 2017 10:11:38 -0400 Date: Tue, 21 Mar 2017 14:11:24 +0000 From: Catalin Marinas To: Will Deacon Cc: Arnd Bergmann , Linux Kernel Mailing List , Linux ARM Subject: Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Message-ID: <20170321141123.GA8319@e104818-lin.cambridge.arm.com> References: <20170314213939.3874497-1-arnd@arndb.de> <20170320190939.GR17263@arm.com> <20170321115156.GB12766@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170321115156.GB12766@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2017 at 11:51:57AM +0000, Will Deacon wrote: > On Tue, Mar 21, 2017 at 11:35:16AM +0100, Arnd Bergmann wrote: > > On Mon, Mar 20, 2017 at 8:09 PM, Will Deacon wrote: > > > > >> > > >> -#define BUG() do { \ > > >> - _BUG_FLAGS(0); \ > > >> - unreachable(); \ > > >> +#define _BUG_FLAGS(flags) __BUG_FLAGS(flags) > > > > > > What is this for? I don't see _BUG_FLAGS used anywhere, but I could > > > be missing some macro expansion. > > > > I think I accidentally left this after removing the last user from an > > intermediate > > version of the patch. Do you want me to send an updated version, or could > > you just drop this line when applying? > > I suspect Catalin can do that when he takes the patch. With that fixup: > > Acked-by: Will Deacon Applied. Thanks. -- Catalin