From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757691AbdCUT7a (ORCPT ); Tue, 21 Mar 2017 15:59:30 -0400 Received: from mail.kernel.org ([198.145.29.136]:50732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752625AbdCUT73 (ORCPT ); Tue, 21 Mar 2017 15:59:29 -0400 Date: Tue, 21 Mar 2017 14:59:23 -0500 From: Bjorn Helgaas To: Geert Uytterhoeven Cc: Bjorn Helgaas , Arnd Bergmann , Michael Ellerman , Linux-Arch , linux-pci , "Luis R. Rodriguez" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH v2 2/4] asm-generic/io.h: Remove unused generic __ioremap() definition Message-ID: <20170321195923.GC5073@bhelgaas-glaptop.roam.corp.google.com> References: <20170320182014.4858.22352.stgit@bhelgaas-glaptop.roam.corp.google.com> <20170320184253.4858.12956.stgit@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2017 at 11:37:11AM +0100, Geert Uytterhoeven wrote: > Hi Björn, > > On Mon, Mar 20, 2017 at 7:42 PM, Bjorn Helgaas wrote: > > Several arches use __ioremap() to help implement the generic ioremap(), > > ioremap_nocache(), and ioremap_wc() interfaces, but this usage is all > > inside the arch/ directory. > > > > The only __ioremap() uses outside arch/ are in the ZorroII RAM disk driver > > and some framebuffer drivers that are only buildable on m68k and powerpc, > > and they use the versions provided by those arches. > > > > There's no need for a generic version of __ioremap(), so remove it. > > These all predate the ioremap_*() variants, and can be converted to > either ioremap_nocache() or ioremap_wt(). > > However, PPC doesn't implement ioremap_wt() yet, so asm-generic will > fall back to the less-efficient nocache variant. > PPC does support __ioremap(..., _PAGE_WRITETHRU), so adding a wrapper > is trivial. Thanks, I'll try adding ioremap_wt() (at least for PPC32) and cleaning this up. > > Signed-off-by: Bjorn Helgaas > > Reviewed-by: Arnd Bergmann > > Regardless, > Acked-by: Geert Uytterhoeven > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds