From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934289AbdCVNJz (ORCPT ); Wed, 22 Mar 2017 09:09:55 -0400 Received: from mail-he1eur01on0133.outbound.protection.outlook.com ([104.47.0.133]:56674 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933720AbdCVNHh (ORCPT ); Wed, 22 Mar 2017 09:07:37 -0400 Authentication-Results: infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=none action=none header.from=nokia.com; From: Tommi Rantala To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin CC: , Tommi Rantala Subject: [PATCH 1/6] perf buildid: do not update SDT cache with null filename Date: Wed, 22 Mar 2017 15:06:19 +0200 Message-ID: <20170322130624.21881-2-tommi.t.rantala@nokia.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170322130624.21881-1-tommi.t.rantala@nokia.com> References: <20170322130624.21881-1-tommi.t.rantala@nokia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [131.228.32.186] X-ClientProxiedBy: DB6P191CA0022.EURP191.PROD.OUTLOOK.COM (10.175.236.160) To DB6PR0701MB2358.eurprd07.prod.outlook.com (10.168.75.12) X-MS-Office365-Filtering-Correlation-Id: 493030ad-4c35-457c-c5f4-08d47124457e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:DB6PR0701MB2358; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;3:hrE6K3LJigRdcgi0iDALai8z/Fd/JAYkp8iY+4cOzvb/Z/0UtoxbcdbpDA8B2UknGS+ZbbH5Gken4ocZUCvU9S75WwwymxCJctKNZnUp4SJlpVH2OHTtRyzu39OhW3d/n6lckzhPUdXUFQDePpaOGs1kldZ43Oa1LLW9o4aGBDER2bjmMOKKcfIIT/HOGxGn3zMwtnWIU3suYD4VcdY9nVrWRwX8WjIo1SVkMgUkyKrVsaoK8MAsmPOPvJLQdGAI7pwBJKM7kfKfMD8FGF5chtjWlhVrViQJ2zI/3U8G2JQ=;25:PC40QiFxbk0lQveoI6en+zjUj+MNGVKhtKdED49mymZGVkErTijD20Y2BEBVOl2vKNjFjpsJokqmjhyzDBupAO0/QSS/AYJ52zYsOD3BjpngmsxDuiTUO8s6/tpvCkUoNHg+QNmjP07aJ3e90soWd0uM9269bSuTdZPG5eloiuUj3ym3u171xCmnDBOG4+HaNoGhVsqgLwDIWKFcQ7MjO8prW3OE+zoRu643M28r+PPXV0fR5alW+65iDJfZqLIsNX3EjJ+ax9pMjlqNoLjEBGbdisBnJAzBirRKkuFnnC1taVAuBXB5G9fI39YHktkOZltdsedjMbZGuM7WkZLLP0ak4SZs07SAgFvUxmJyZC0gE1G4zcO8C/aQISb9L7BDBUZdrE8H8hdn19eEQqlbUPnH8KgpD+b4yeZGxByt7pTVIRNBwzoruvywQkQ0n5jxVViqEH8Y/wi0JNVspbHTDg== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;31:1yIbGqi0rooJclWMvwhLARUYTzT+6JjofMQhbA3BZ26KGo0/K+X/2paeYTzHZwQw7FfYNkGMVv62yMVUE9LkrutnQFwT3SQiWzZf/QuJxMpuC3pM1cymC8qOsoDQe+ASok8Ql4Vkf1hjZDM5LycsXV3cYXFrnJUbybCJThtX3Sz7B9hLp9DP9f+Nh6uHVXxk1tmrN60AgBSa4s5aJ6L7B0n+p9u99EEvum2YBA3bhko=;20:Ed65h5AzfBlknQqh6qMWANhNGxXQsdaA/xRnU9t+L/p/gd6X5+pCGCTcJgj2xo5MBRacovWh++7r3NizZK5mLDukmcCtICueVcub+St699S1fG7HiWFQmJLjte8yBZH/tBLxKexh6u/wDeHdROyYW+akhKrfFj/nr+9baFGgRtM+CYD6DlffcBGUW1PKc+bWX6Bp15vNK/rzxbbDiDtCMeEya/FNASl1/hlXx1dZmd2SaeED0UUw2WpDGYQl2YyGQu/muJgmhfqS34HtacYevOwGb5sg6tvpUzCgnZENGe93lUSEIRwltbgUd66cekliml8xOOAUuBCJDB+AbtNNiXHYEv9RslrIFXjwSdNTTOXlosRJtYWzM9uzBkYTIMIl3ivPK2H7yY7kxB7WurhLouRZ1WnatrYK1bsv2EUV8zRqjtvQ2PvKv7BnI5DbiauSPHhJ9W+JTkgVZ/XBbBpHHfaPiBfqvLXTgMu+l4rGjkSo+i0pSnDhyUfXdpRFSeYX X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(82608151540597); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123558025)(20161123555025)(6072148);SRVR:DB6PR0701MB2358;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0701MB2358; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;4:xsSOUzVWAKMAXEETRJijquDeTvJlQtdMMaa9z5z+m4P3IdfJneJ8yw7zMDc7dNZVIwCjN3kLwFHEX9XywEQZkCud/kxWMuCfiz4nmKFLa7nWk7Yv17+av39Q8N21OJgHBzB1clC7h5XCSoL1uCSWJwhbFUt4mw6iep78gIRTOsfEai8jmozoDJ0Fn26vIR9gVJ77XSQme4I6MVBHrrcRXc5CiKEDnUXFUYJvgUGjlu2SubAsUrF+rcXwgTaaTwAi9dwhpAVHRD//6hhbSrAm8SrwllfztaucZq3XbEjtD4cvyKlDA8B1d+Lq3+I8W0Smyfbo5LLpTwUbTliDcp8iuc4teSga6zAjfghQoJDsgtvD8xfN9QlZtfVGAp7XLpIHnFZAvFLp6BrLWe93hxrpjRhAcLRZvUmS9UsiU31cn8RN2RhWTLwyiOUULG24M9OxqSK6D+RDZEfbN4FEb0tHvJyJSaJvXURsl5ZwZW+qrYQUYV21ApG+pfMAjFAfpp6oWyRa8ojfNo991vRgZj1A6dUm9tea8xdhkhOG0Zrjj6dYd3DELWyrh2hY9IBS529ZRDelLnrqMdBnnuce1bTEnaIXTwM9eR+jcdF8GDhGhi46ugpqkQUMhs3YpvXXXGez0ZvdbBcy75Te7BU9R3mMHD9r1u2b0YDwVbYbuE35E80= X-Forefront-PRVS: 02543CD7CD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39840400002)(39860400002)(39410400002)(39450400003)(39850400002)(50466002)(66066001)(42186005)(6486002)(6506006)(81166006)(2950100002)(6666003)(47776003)(5003940100001)(8676002)(6512007)(5660300001)(2906002)(103116003)(50986999)(76176999)(25786009)(4326008)(36756003)(38730400002)(107886003)(1076002)(189998001)(50226002)(33646002)(53936002)(15650500001)(3846002)(6116002)(48376002)(7736002)(305945005)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0701MB2358;H:trfedora.emea.nsn-net.net;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0701MB2358;23:eriOYqEBRHT73WcSs3HI0bZLi2d3h51Q8JRx8qk?= =?us-ascii?Q?j5uPhC0zpkkHoUxgXhgX5KEkMALXp4ezVZU8H5Tjo5JszWbhDilBTYOQVP5w?= =?us-ascii?Q?5WhzF4dz2VPSsI3vMwfvKlszrcGCfh/xnH2lgNO+1iBl+gFOMNXFlyMq8QpU?= =?us-ascii?Q?3Kk/p8ODJw5dPua7hK8SegUQdCNHqNyZLdkGfhVve6P/8Dh1AKD9+cSi3yCH?= =?us-ascii?Q?zPy+DfZQToBMzsyXK83ekz+OMNfioZrBwuSqX/R+Sot/GagtOfBakdNY/gcG?= =?us-ascii?Q?vA0+mneh6NIB4dVe9jsKBOeXkVR3kSAyHQrhyyUftlGFX6/1L0EEe8RCnxr8?= =?us-ascii?Q?B/OQj+tuRX6q8LuswB23cfRNf4ZJZBQ1fk9/40XeYBkq0KYTJLYHLV3SqJDN?= =?us-ascii?Q?pR17f8g8u7BdIw/gpNtKX7tfN3TQzR3LwSeEIsC0JO+ZAtSPqZtc1y/SOp6w?= =?us-ascii?Q?Y3X2OYoEIAP7MyJu24u/feslL3TxbPzlJDuYwgSSLmKuxH3lEhP4vCulL+oY?= =?us-ascii?Q?LL74tOPLFuKC2E4T/6epabnzOehbxODInfaLEqhs1O0N5fzoTp/DT658QCym?= =?us-ascii?Q?27X1x2/BvyiCJrKU4nQZODLw68Tek9Txij8wNKdA2RK/espsR3K+oTeFkT6Z?= =?us-ascii?Q?/8bod7yoqCiNqVY+gmSsB4TMevQZnBbeREFEOiGcDB79ty3EY8N6vMYgo169?= =?us-ascii?Q?BwDc0NWBuzZX+pOEqjUEl1Nw/RUwvYolYKPFXqqyfh0z1M4j6LqmrRGNUUJY?= =?us-ascii?Q?ixQ4pTTvHmB02SAg2fu+rAjVUujaNW8lczaSqzB7bDm4NLZknz/aN/MuzrFR?= =?us-ascii?Q?FQTXnWICK01cLkCvp3KjFGeqi/Jtzya59FKjeSCyLKmXci3B1/hrttislmur?= =?us-ascii?Q?/gm5aBUTN2e4vz9n+ikIYphv2GFa82m7Ar1SaaOX5puycRY9zA48oIqNO5SG?= =?us-ascii?Q?PYIWqgMaqqh3zG9mNvx9yWj5oaHrC5K2vKMfKYQLhN7KUxQcl6VSZxdZYDvC?= =?us-ascii?Q?OmkS+hWQuoZpwNTAwZj+hfq+v8aJKV3WLOaY/9r7hHdXQOCQ9SPHJnfEJiHa?= =?us-ascii?Q?L101ExJE=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;6:Xl0ok9WmZ94h5xjCQpywQDj1whQakED/gc/LxpYJ0KJAX4iJop+FJPlvIkmfu2zLotuv6mwzn7l+PzspRFdQQLy/MkBMUQ5Et13jA7R3KpPVonUeO0QtalraviCwSm3vcetSN7fn1ER8i/z1+hCa0JJFYaciyzAmTBB8E9cgskVE7DRY9gXVPPI8/PrJDsBVnQSsf2XX6xfsOI/KuO686uw4jy6beQUpLCT5izspGicURtvs5VL18ZD1DYg4QjqNbHZfBoX2bStUyoXi2MJMV4JkCtMg1zxQ7FIjtpR0pRVe8osnJ7Ag1hUkYVfiLNQZg1nLFGKlTqteUwpSHck/QX/DZGfu9WnYRh8+i1We7aB2EL4+NsJBN8sHCNyo8So6ihquViScF9I21Nt4Pl0nb6AKAnSAcaxaq42Kyys+JxA=;5:ssOKPzY9ZnYt/sBnsCDfrd6j4F1zxoV2X7WZn7kDq9YdYaW5L3CiwahNXu87zAYBN80UZ19hs/bgA4rLJO+/DFcAvZAorC3DIym0drdp+XkRhRXIsLh0+WTdQzSPsFMb9Fi7qJzA60byFNZ+my3vNQ==;24:SnP//JCaJmNXTVdxHGyQPCfV9PfU6G9fav0X2UJpSRegxrqCxOPAKVEbpKwJwUi6vHLH/ZglVtzO8qFGDAcPK5mFPHzBxg+nX+NWlWUUvt4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0701MB2358;7:+TIyMdT/A4GWRIeUShOgAYuAFOxdSxF2+d/GvfWPjIV9SPqU48318F1yr0FuxDYz/vKFmYH+nyivifP4sx3hfzl0/dKNeHznX8kd/bLjNpvwY7CbhpV4v+3kjeGp+i/EREMnfNLgSsZCS5MaDWtqOA8vJKDJekU8jScr7pAyE12P2aPsOpRCM6uztxa9OjYKPeF/6nlXo4WJEHbfe5ERSicVCpA8NO56Ner4XeXSO57qP4nFwPFfpcLsolrAbDfiFPMQRuzLVseSPtrRkZ8a0kuzxcGfiEyY0/qbDNsr7d9jviCp07oQMmwVzxZt8yX9ltXU68mmjs7Tqil6XZXKyA== X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2017 13:06:35.9985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0701MB2358 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Valgrind was complaining: ==2633== Syscall param open(filename) points to unaddressable byte(s) ==2633== at 0x5281CC0: __open_nocancel (syscall-template.S:84) ==2633== by 0x537D38: open (fcntl2.h:53) ==2633== by 0x537D38: get_sdt_note_list (symbol-elf.c:2017) ==2633== by 0x5396FD: probe_cache__scan_sdt (probe-file.c:700) ==2633== by 0x49EA2C: build_id_cache__add_sdt_cache (build-id.c:625) ==2633== by 0x49EA2C: build_id_cache__add_s (build-id.c:697) ==2633== by 0x49EE72: build_id_cache__add_b (build-id.c:717) ==2633== by 0x49EE72: dso__cache_build_id (build-id.c:782) ==2633== by 0x49F190: __dsos__cache_build_ids (build-id.c:793) ==2633== by 0x49F190: machine__cache_build_ids (build-id.c:801) ==2633== by 0x49F190: perf_session__cache_build_ids (build-id.c:815) ==2633== by 0x4CD4F2: write_build_id (header.c:165) ==2633== by 0x4D26F7: do_write_feat (header.c:2296) ==2633== by 0x4D26F7: perf_header__adds_write (header.c:2335) ==2633== by 0x4D26F7: perf_session__write_header (header.c:2414) ==2633== by 0x43B324: __cmd_record (builtin-record.c:1154) ==2633== by 0x43B324: cmd_record (builtin-record.c:1839) ==2633== by 0x455A07: __cmd_record (builtin-kmem.c:1868) ==2633== by 0x455A07: cmd_kmem (builtin-kmem.c:1944) ==2633== by 0x497150: run_builtin (perf.c:359) ==2633== by 0x428CE0: handle_internal_command (perf.c:421) ==2633== by 0x428CE0: run_argv (perf.c:467) ==2633== by 0x428CE0: main (perf.c:614) ==2633== Address 0x0 is not stack'd, malloc'd or (recently) free'd Signed-off-by: Tommi Rantala --- tools/perf/util/build-id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index e528c40..234859f 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c @@ -690,7 +690,7 @@ int build_id_cache__add_s(const char *sbuild_id, const char *name, err = 0; /* Update SDT cache : error is just warned */ - if (build_id_cache__add_sdt_cache(sbuild_id, realname) < 0) + if (realname && build_id_cache__add_sdt_cache(sbuild_id, realname) < 0) pr_debug4("Failed to update/scan SDT cache for %s\n", realname); out_free: -- 2.9.3