From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760135AbdCVOhu (ORCPT ); Wed, 22 Mar 2017 10:37:50 -0400 Received: from foss.arm.com ([217.140.101.70]:41958 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759887AbdCVOhf (ORCPT ); Wed, 22 Mar 2017 10:37:35 -0400 Date: Wed, 22 Mar 2017 14:37:29 +0000 From: Catalin Marinas To: Arnd Bergmann Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Message-ID: <20170322143729.GB25645@e104818-lin.cambridge.arm.com> References: <20170314213939.3874497-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170314213939.3874497-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Tue, Mar 14, 2017 at 10:39:21PM +0100, Arnd Bergmann wrote: > This mirrors commit e9c38ceba8d9 ("ARM: 8455/1: define __BUG as > asm(BUG_INSTR) without CONFIG_BUG") to make the behavior of > arm64 consistent with arm and x86, and avoids lots of warnings in > randconfig builds, such as: > > kernel/seccomp.c: In function '__seccomp_filter': > kernel/seccomp.c:666:1: error: no return statement in function returning non-void [-Werror=return-type] > > Signed-off-by: Arnd Bergmann A side-effect of this patch is that it turns WARN into BUG. I hit the WARN_ONCE in arch/arm64/kernel/efi.c:34 (on Juno with 64K pages) and with your patch applied, the kernel panics. -- Catalin