From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935448AbdCVPlc (ORCPT ); Wed, 22 Mar 2017 11:41:32 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38425 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935021AbdCVPlY (ORCPT ); Wed, 22 Mar 2017 11:41:24 -0400 Date: Wed, 22 Mar 2017 16:41:14 +0100 From: Daniel Lezcano To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Rutland , Catalin Marinas , Will Deacon , Scott Wood , Hanjun Guo , Ding Tianhong , dann frazier Subject: Re: [PATCH v2 06/18] arm64: arch_timer: Add infrastructure for multiple erratum detection methods Message-ID: <20170322154114.GE30499@mai> References: <20170320174829.28182-1-marc.zyngier@arm.com> <20170320174829.28182-7-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170320174829.28182-7-marc.zyngier@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 20, 2017 at 05:48:17PM +0000, Marc Zyngier wrote: > We're currently stuck with DT when it comes to handling errata, which > is pretty restrictive. In order to make things more flexible, let's > introduce an infrastructure that could support alternative discovery > methods. No change in functionality. > > Reviewed-by: Hanjun Guo > Signed-off-by: Marc Zyngier > --- > arch/arm64/include/asm/arch_timer.h | 7 +++- > drivers/clocksource/arm_arch_timer.c | 80 +++++++++++++++++++++++++++++++----- > 2 files changed, 75 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h > index b4b34004a21e..5cd964e90d11 100644 > --- a/arch/arm64/include/asm/arch_timer.h > +++ b/arch/arm64/include/asm/arch_timer.h > @@ -37,9 +37,14 @@ extern struct static_key_false arch_timer_read_ool_enabled; > #define needs_unstable_timer_counter_workaround() false > #endif > > +enum arch_timer_erratum_match_type { > + ate_match_dt, > +}; > > struct arch_timer_erratum_workaround { > - const char *id; /* Indicate the Erratum ID */ > + enum arch_timer_erratum_match_type match_type; Putting the match_fn instead will be much more simpler and the code won't have to deal with ate_match_type, no ? [ ... ] > +static void arch_timer_check_ool_workaround(enum arch_timer_erratum_match_type type, > + void *arg) > +{ > + const struct arch_timer_erratum_workaround *wa; > + ate_match_fn_t match_fn = NULL; > + > + if (static_branch_unlikely(&arch_timer_read_ool_enabled)) > + return; > + Why is this check necessary ? [ ... ] -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog