From: Sebastian Reichel <sre@kernel.org>
To: Wojciech Ziemba <Wojciech.Ziemba@VERIFONE.com>
Cc: Wojciech Ziemba <wo.ziemba@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] power: supply: Add driver for TI BQ2416X battery charger
Date: Thu, 23 Mar 2017 14:54:36 +0100 [thread overview]
Message-ID: <20170323135436.v7epznjbtclqkfsd@earth> (raw)
In-Reply-To: <BN6PR03MB2963F42E5F6AC2ECCDC5722B9F3C0@BN6PR03MB2963.namprd03.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1552 bytes --]
Hi,
On Wed, Mar 22, 2017 at 01:53:19PM +0000, Wojciech Ziemba wrote:
> [...]
>
> >> and a number of knobs for controlling the charging process
> > missing sysfs ABI documentation. Most of them are probably either
> > not needed, or should become standard POWER_SUPPLY_PROP_ properties.
>
> Well, it is up to you. POWER_SUPPLY props are already there.
> If any new POWER_SUPPLY props should be introduced, it is an open question.
> I agree sysfs knobs could be not needed, but many PSY drivers
> still use them. Couldn't them still be useful even if don't fit the model directly?
> Especially for more specialized embedded systems?
Yes they may, they also may not. Let's add them once they are
needed, because adding them means, that they become ABI.
> [...]
>
> >> +- ti,safety-timer: Safety timer. enum:
> >> + - TMR_27MIN (0)
> >> + - TMR_6H (1)
> >> + - TMR_9H (2)
> >> + - TMR_OFF (3)
> > This does not belong into DT. Just always set it to 27 minutes and
> > properly reset the timer in the driver. You will also need a suspend
> > handler, that disables the timer (or wakeup every now and then to
> > reset it).
>
> Do you mean, more flexible safety timer based on minimal 27min reset?
> Will address wakeup in suspend, separately in this driver.
I mean just always use TMR_27MIN in the driver + watchdog to keep
the system charging. You can change the timer to something bigger
in the suspend routine.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-03-23 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 1:09 [PATCH] power: supply: Add driver for TI BQ2416X battery charger Wojciech Ziemba
2017-02-07 3:00 ` Liam Breck
2017-02-07 11:08 ` Andy Shevchenko
2017-03-20 5:58 ` Sebastian Reichel
2017-03-22 13:53 ` Wojciech Ziemba
2017-03-23 13:54 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323135436.v7epznjbtclqkfsd@earth \
--to=sre@kernel.org \
--cc=Wojciech.Ziemba@VERIFONE.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wo.ziemba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).