From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936575AbdCXPp2 (ORCPT ); Fri, 24 Mar 2017 11:45:28 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34457 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757348AbdCXPoy (ORCPT ); Fri, 24 Mar 2017 11:44:54 -0400 Date: Fri, 24 Mar 2017 10:44:51 -0500 From: Rob Herring To: Viresh Kumar Cc: Rafael Wysocki , ulf.hansson@linaro.org, Kevin Hilman , Viresh Kumar , Nishanth Menon , Stephen Boyd , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , lina.iyer@linaro.org, rnayak@codeaurora.org, devicetree@vger.kernel.org Subject: Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for power-domains Message-ID: <20170324154451.ljszby3mhc4rlgnw@rob-hp-laptop> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 20, 2017 at 03:02:13PM +0530, Viresh Kumar wrote: > Power-domains need to express their active states in DT and what's > better than OPP table for that. > > This patch allows power-domains to reuse OPP tables to express their > active states. The "opp-hz" property isn't a required property anymore > as power-domains may not always use them. Then maybe you shouldn't be trying to make OPP table work here. At that point you just need a table of voltage(s) per performance state? > Add a new property "domain-performance-state", which will contain > positive integer values to represent performance levels of the > power-domains as described in this patch. Why not reference the OPP entries from the domain: performance-states = <&opp1>, <&opp2>; Just thinking out loud, not saying that is what you should do. The continual evolution of power (management) domain, idle state, and OPP bindings is getting tiring. > Signed-off-by: Viresh Kumar > --- > Documentation/devicetree/bindings/opp/opp.txt | 73 ++++++++++++++++++++++++++- > 1 file changed, 71 insertions(+), 2 deletions(-) >