From: Steven Rostedt <rostedt@goodmis.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, Borislav Petkov <bp@alien8.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram
Date: Mon, 27 Mar 2017 11:24:33 -0400 [thread overview]
Message-ID: <20170327112433.728ba8c1@gandalf.local.home> (raw)
In-Reply-To: <d8fd5cfd-e273-ad29-9281-2436cb0c3723@molgen.mpg.de>
On Mon, 27 Mar 2017 17:01:53 +0200
Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> > + /*
> > + * When resuming from suspend-to-ram, this function can be indirectly
> > + * called from early CPU startup code while the CPU is in real mode,
> > + * which would fail miserably. Make sure the stack pointer is a
> > + * virtual address.
> > + *
> > + * This check isn't as accurate as virt_addr_valid(), but it should be
> > + * good enough for this purpose, and it's fast.
> > + */
> > + if (unlikely((long)__builtin_frame_address(0) >= 0)) return;
>
> The coding style requires the `return;` to be on a separate line.
Correct, and new versions of a patch should always start a new thread
(unless it's a single update of a patch in a long patch series).
Otherwise they get ignored. (hint hint)
-- Steve
>
> > +
> > if (unlikely(ftrace_graph_is_dead()))
> > return;
>
next prev parent reply other threads:[~2017-03-27 15:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 13:56 [PATCH] acpi: fix incompatibility with mcount-based function graph tracing Josh Poimboeuf
2017-03-16 14:41 ` Steven Rostedt
2017-03-21 20:44 ` Paul Menzel
2017-03-22 0:04 ` Paul Menzel
2017-03-24 18:12 ` Josh Poimboeuf
2017-03-24 18:41 ` Steven Rostedt
2017-03-25 13:20 ` Rafael J. Wysocki
2017-03-27 14:08 ` Josh Poimboeuf
2017-03-27 14:54 ` [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram Josh Poimboeuf
2017-03-27 15:01 ` Paul Menzel
2017-03-27 15:20 ` [PATCH v2] " Josh Poimboeuf
2017-03-27 15:24 ` Steven Rostedt [this message]
2017-03-28 9:51 ` [PATCH] " Paul Menzel
2017-03-28 15:39 ` Steven Rostedt
2017-03-28 15:55 ` Josh Poimboeuf
2017-03-28 21:12 ` Rafael J. Wysocki
2017-03-28 21:42 ` Josh Poimboeuf
2017-03-28 21:47 ` Rafael J. Wysocki
2017-03-27 16:59 ` [PATCH] acpi: fix incompatibility with mcount-based function graph tracing Rafael J. Wysocki
2017-03-26 20:57 [PATCH] trace: Make trace_hwlat timestamp y2038 safe Deepa Dinamani
2017-03-27 9:25 ` kbuild test robot
2017-03-27 9:55 ` Arnd Bergmann
2017-03-27 14:28 ` Steven Rostedt
2017-03-27 14:53 ` Arnd Bergmann
2017-03-27 15:30 ` Steven Rostedt
2017-03-27 15:35 ` Arnd Bergmann
2017-03-27 16:11 ` Steven Rostedt
2017-03-27 21:02 ` Deepa Dinamani
2017-03-28 7:26 ` Arnd Bergmann
2017-03-27 10:04 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327112433.728ba8c1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bp@alien8.de \
--cc=jpoimboe@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=rjw@rjwysocki.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).