From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753405AbdC0PbH (ORCPT ); Mon, 27 Mar 2017 11:31:07 -0400 Received: from mail.kernel.org ([198.145.29.136]:47014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752764AbdC0Pa7 (ORCPT ); Mon, 27 Mar 2017 11:30:59 -0400 Date: Mon, 27 Mar 2017 11:30:28 -0400 From: Steven Rostedt To: Arnd Bergmann Cc: Paul Menzel , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Borislav Petkov , "Rafael J. Wysocki" Subject: Re: [PATCH] trace: Make trace_hwlat timestamp y2038 safe Message-ID: <20170327113028.7f74c9b8@gandalf.local.home> In-Reply-To: References: <6559f36c6c6cdc2552b0bccf31de967367aa790d.1489672478.git.jpoimboe@redhat.com> <20170324181254.gouyrbmppukrrbb6@treble> <20170324144114.16a37d47@gandalf.local.home> <5766300.HtmE7iLEgV@aspire.rjw.lan> <20170327140843.fx5y32rnc3mqiyke@treble> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Mar 2017 16:53:09 +0200 Arnd Bergmann wrote: > > Actually, I believe that "%zd" will work. It's made to work with size_t > > which is long long on 32 and long on 64. > > size_t is always 'long', not 'long long'. We have %pad for dma_addr_t > which may be 'long' or 'long long', but it is configuration dependent > which one it is on 32-bit. Ah your right. It was that it was defined as "int" on 32 and "long" on 64, and that caused problems with warnings when using "%d" when it was defined as long. > > We could probably introduce a %pts format string for timespec64 > and have that pretty-printed. Hmm, probably don't want a %p as that suggests its a pointer, which it should not be. Unless we pass in the address of the number. -- Steve