From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: rkrcmar@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] kvm/x86/vmx: report KVM_SYSTEM_EVENT_CRASH on triple fault
Date: Tue, 28 Mar 2017 10:51:19 -0500 [thread overview]
Message-ID: <20170328155119.qkanbuai4l6kmsq7@treble> (raw)
In-Reply-To: <1394433d-528a-06c1-6684-74c4c1dd3081@redhat.com>
On Tue, Mar 28, 2017 at 02:39:34PM +0200, Paolo Bonzini wrote:
>
>
> On 28/03/2017 13:46, Josh Poimboeuf wrote:
> > On Tue, Mar 28, 2017 at 03:51:01AM -0400, Paolo Bonzini wrote:
> >>
> >>> While debugging a kernel issue, I found that QEMU always reboots when an
> >>> x86 triple fault occurs, which complicates debugging. QEMU and libvirt
> >>> have a facility for creating a dump when KVM reports
> >>> KVM_SYSTEM_EVENT_CRASH. So change the VMX triple fault handler to do
> >>> that. This gives user space the ability to decide whether to dump,
> >>> pause, shutdown, or reboot.
> >>
> >> You probably want QEMU's -no-reboot option.
> >>
> >> Triple faults are already reported to userspace with KVM_EXIT_SHUTDOWN,
> >> and it's up to userspace to decide what to do with it. This patch cannot
> >> be applied, because there are guests that do a triple-fault intentionally
> >> in order to reset the machine.
> >
> > Ok. Any idea how to force libvirt to create a dump? It has a
> > 'coredump-destroy' option, but that only seems to work with 'on_crash':
> >
> > https://libvirt.org/formatdomain.html#elementsEvents
>
> Probably QEMU, when invoked with -no-shutdown -no-reboot, should treat
> KVM_EXIT_SHUTDOWN as a panic. I can have a go at it, but note that QEMU
> is now in hard freeze for the next release, so it will take a while.
>
> However you're using libvirt and it doesn't use -no-reboot.
>
> It's probably possible for libvirt to use -no-reboot more often. The
> price would be that if libvirtd crashes and a VM wants to reset, then
> the VM gets stuck.
>
> Alternatively, we could generalize -no-shutdown and -no-reboot to
> something like:
>
> -action reset=stop|restart|quit,
> poweroff=stop|quit,
> triple-fault=stop|panic|restart|quit
>
> and teach libvirt about it. The current semantics map relatively easily
> to the new option:
>
> | reset | poweroff | triple-fault
> --------------------------+-------------+------------+-------------------
> no option | restart | quit | restart
> -no-shutdown | restart | stop | restart
> -no-reboot | quit | quit | quit
> -no-shutdown -no-reboot | stop | stop | stop (panic?)
I like your new option proposal. It makes a lot more sense, at least
from the perspective of a novice user (me).
Having some kind of framework in place for dealing with triple faults --
either pausing or dumping -- would be very useful. Right now I can't
even get libvirt to pause when it happens.
--
Josh
prev parent reply other threads:[~2017-03-28 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 19:25 [PATCH] kvm/x86/vmx: report KVM_SYSTEM_EVENT_CRASH on triple fault Josh Poimboeuf
2017-03-28 7:51 ` Paolo Bonzini
2017-03-28 11:46 ` Josh Poimboeuf
2017-03-28 12:39 ` Paolo Bonzini
2017-03-28 15:51 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328155119.qkanbuai4l6kmsq7@treble \
--to=jpoimboe@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).