From: David Miller <davem@davemloft.net>
To: Vladislav.Zakharov@synopsys.com
Cc: netdev@vger.kernel.org, edumazet@google.com,
eladkan@mellanox.com, noamca@mellanox.com,
linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH] ezchip: nps_enet: check if napi has been completed
Date: Wed, 29 Mar 2017 14:30:14 -0700 (PDT) [thread overview]
Message-ID: <20170329.143014.2001816338079751776.davem@davemloft.net> (raw)
In-Reply-To: <1490784106-14489-1-git-send-email-vzakhar@synopsys.com>
From: Vlad Zakharov <Vladislav.Zakharov@synopsys.com>
Date: Wed, 29 Mar 2017 13:41:46 +0300
> After a new NAPI_STATE_MISSED state was added to NAPI we can get into
> this state and in such case we have to reschedule NAPI as some work is
> still pending and we have to process it. napi_complete_done() function
> returns false if we have to reschedule something (e.g. in case we were
> in MISSED state) as current polling have not been completed yet.
>
> nps_enet driver hasn't been verifying the return value of
> napi_complete_done() and has been forcibly enabling interrupts. That is
> not correct as we should not enable interrupts before we have processed
> all scheduled work. As a result we were getting trapped in interrupt
> hanlder chain as we had never been able to disabale ethernet
> interrupts again.
>
> So this patch makes nps_enet_poll() func verify return value of
> napi_complete_done() and enable interrupts only in case all scheduled
> work has been completed.
>
> Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com>
Applied.
Eric, if this is really required now, we have 148 broken drivers still.
next prev parent reply other threads:[~2017-03-29 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 10:41 [PATCH] ezchip: nps_enet: check if napi has been completed Vlad Zakharov
2017-03-29 14:52 ` Eric Dumazet
2017-03-29 21:30 ` David Miller [this message]
2017-03-29 21:41 ` Eric Dumazet
2017-03-30 9:16 ` Vlad Zakharov
2017-03-30 13:25 ` Eric Dumazet
2017-04-26 12:56 ` Vlad Zakharov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329.143014.2001816338079751776.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Vladislav.Zakharov@synopsys.com \
--cc=edumazet@google.com \
--cc=eladkan@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=noamca@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).