From: Masami Hiramatsu <mhiramat@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: acme@redhat.com, alexis.berlemont@gmail.com,
linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
naveen.n.rao@linux.vnet.ibm.com, mpe@ellerman.id.au,
hemant@linux.vnet.ibm.com
Subject: Re: [PATCH v3 0/3] perf/sdt: Hardening argument support
Date: Wed, 29 Mar 2017 00:29:29 +0900 [thread overview]
Message-ID: <20170329002929.54e022d61751a84221a4635e@kernel.org> (raw)
In-Reply-To: <20170328094754.3156-1-ravi.bangoria@linux.vnet.ibm.com>
Hi Arnaldo,
please pull this, I've already acked to this series.
Thank you,
On Tue, 28 Mar 2017 15:17:51 +0530
Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
> SDT event argument support on x86 is recently added to Perf. But
> there are couple of issues with it.
>
> It lacks renaming mapping for few 8 bit registers: al, bl, cl, dl,
> ah, bh, ch and dh. SDT events using these registers in arguments
> are failing at 'perf probe'. Add renaming logic to them. (patch 1)
>
> It still has x86 specific code in general code. It also fails to
> convert arguments having no offset but still surrounds register with
> parenthesis for ex. 8@(%rdi) is converted to +(%di):u64, which is
> rejected by uprobe_events. Also, 'perf probe' is failing for *all SDT
> events on all archs except x86*. Solve these issues. (patch 2)
>
> Add argument parser for powerpc. (patch 3)
>
> Changes in v3:
> - (patch 1) Add renaming entries for ah, bh, ch and dh registers.[1]
>
> - (patch 1) v2 contains silly copy-paste error. It maps all al, bl...
> registers to ax. Fix that.
>
> - (patch 2) Fix typo 'constant'.
>
> - Patch 2 is not applying cleanly on top of patch 1 after adding
> ah, bh... registers. Fix that.
>
> v2: https://lkml.org/lkml/2017/3/27/118
>
> This patch is prepared on top of acme/perf/core.
>
> [1] https://lkml.org/lkml/2017/3/27/462
>
> Ravi Bangoria (3):
> perf/sdt/x86: Add renaming logic for (missing) 8 bit registers
> perf/sdt/x86: Move OP parser to tools/perf/arch/x86/
> perf/sdt/powerpc: Add argument support
>
> tools/perf/arch/powerpc/util/perf_regs.c | 111 ++++++++++++++++++
> tools/perf/arch/x86/util/perf_regs.c | 187 +++++++++++++++++++++++++------
> tools/perf/util/perf_regs.c | 6 +-
> tools/perf/util/perf_regs.h | 11 +-
> tools/perf/util/probe-file.c | 132 +++++++---------------
> 5 files changed, 313 insertions(+), 134 deletions(-)
>
> --
> 2.9.3
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2017-03-28 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 9:47 [PATCH v3 0/3] perf/sdt: Hardening argument support Ravi Bangoria
2017-03-28 9:47 ` [PATCH v3 1/3] perf/sdt/x86: Add renaming logic for (missing) 8 bit registers Ravi Bangoria
2017-04-02 19:12 ` [tip:perf/core] " tip-bot for Ravi Bangoria
2017-03-28 9:47 ` [PATCH v3 2/3] perf/sdt/x86: Move OP parser to tools/perf/arch/x86/ Ravi Bangoria
2017-04-02 19:12 ` [tip:perf/core] " tip-bot for Ravi Bangoria
2017-03-28 9:47 ` [PATCH v3 3/3] perf/sdt/powerpc: Add argument support Ravi Bangoria
2017-04-05 5:50 ` [tip:perf/core] perf sdt powerpc: " tip-bot for Ravi Bangoria
2017-03-28 15:29 ` Masami Hiramatsu [this message]
2017-03-28 15:40 ` [PATCH v3 0/3] perf/sdt: Hardening " Arnaldo Carvalho de Melo
2017-04-01 5:31 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329002929.54e022d61751a84221a4635e@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexis.berlemont@gmail.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).