From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752571AbdC2EiJ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Mar 2017 00:38:09 -0400
Received: from mail-pf0-f180.google.com ([209.85.192.180]:34563 "EHLO
        mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750954AbdC2EiG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Mar 2017 00:38:06 -0400
Date: Tue, 28 Mar 2017 21:37:55 -0700
From: Eduardo Valentin <edubezval@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Keerthy <j-keerthy@ti.com>, rui.zhang@intel.com,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        robh+dt@kernel.org, t-kristo@ti.com
Subject: Re: [PATCH v2 0/8] thermal: ti-soc-thermal: Migrate slope/offset
 data to device tree
Message-ID: <20170329043753.GB1596@localhost.localdomain>
References: <1489046762-11288-1-git-send-email-j-keerthy@ti.com>
 <64ab8413-6cf1-864f-0550-9c8db59523f7@ti.com>
 <20170323205256.GO10760@atomide.com>
 <a410d37f-92e5-39b4-ac6c-158673163cb0@ti.com>
 <20170324142610.GX10760@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170324142610.GX10760@atomide.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Keerthy,

On Fri, Mar 24, 2017 at 07:26:10AM -0700, Tony Lindgren wrote:
> * Keerthy <j-keerthy@ti.com> [170323 20:29]:
> > 
> > 
> > On Friday 24 March 2017 02:22 AM, Tony Lindgren wrote:
> > > * Keerthy <j-keerthy@ti.com> [170321 20:45]:
> > >>
> > >>
> > >> On Thursday 09 March 2017 01:35 PM, Keerthy wrote:
> > >>> Currently the slope and offset values for calculating the
> > >>> hot spot temperature of a particular thermal zone is part
> > >>> of driver data. Pass them here instead and obtain the values
> > >>> while of node parsing.
> > >>>
> > >>> Tested for the slope and constant values on DRA7-EVM, OMAP3-BEAGLE. 

Have you tried on boards that need negative coefficients?

https://patchwork.kernel.org/patch/9619577/

> > >>
> > >> Hi Eduardo,
> > >>
> > >> If the series looks okay could you please pull this?
> > > 
> > > Also.. Are the dts changes safe for me to pick separately?
> > 
> > Yes Tony they are safe to pulled separately.
> 
> OK applying patches 1 - 5 of this series into omap-for-v4.12/dt-v2.

Keerthy,

The only thing I want you to confirm is if you are really getting the
negative coefficients, because currently of-thermal reads the array
using an OF helper that understands only unsigned. For this reason, I
will be queueing your patches only for next merge window, not as a fix,
not for rc's.


> 
> Thanks,
> 
> Tony