From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Suchanek <msuchanek@suse.de>,
"Leonidas S. Barbosa" <leosilva@linux.vnet.ibm.com>,
Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] crypto: vmx: Remove dubiously licensed crypto code
Date: Wed, 29 Mar 2017 16:51:35 +0200 [thread overview]
Message-ID: <20170329145135.GA28057@kroah.com> (raw)
In-Reply-To: <20170329125639.14288-1-msuchanek@suse.de>
On Wed, Mar 29, 2017 at 02:56:39PM +0200, Michal Suchanek wrote:
> While reviewing commit 11c6e16ee13a ("crypto: vmx - Adding asm
> subroutines for XTS") which adds the OpenSSL license header to
> drivers/crypto/vmx/aesp8-ppc.pl licensing of this driver came into
> qestion. The whole license reads:
>
> # Licensed under the OpenSSL license (the "License"). You may not use
> # this file except in compliance with the License. You can obtain a
> # copy
> # in the file LICENSE in the source distribution or at
> # https://www.openssl.org/source/license.html
>
> #
> # ====================================================================
> # Written by Andy Polyakov <appro@openssl.org> for the OpenSSL
> # project. The module is, however, dual licensed under OpenSSL and
> # CRYPTOGAMS licenses depending on where you obtain it. For further
> # details see http://www.openssl.org/~appro/cryptogams/.
> # ====================================================================
>
> After seeking legal advice it is still not clear that this driver can be
> legally used in Linux. In particular the "depending on where you obtain
> it" part does not make it clear when you can apply the GPL and when the
> OpenSSL license.
>
> I tried contacting the author of the code for clarification but did not
> hear back. In absence of clear licensing the only solution I see is
> removing this code.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> MAINTAINERS | 12 -
> drivers/crypto/Kconfig | 8 -
> drivers/crypto/Makefile | 1 -
> drivers/crypto/vmx/.gitignore | 2 -
> drivers/crypto/vmx/Kconfig | 9 -
> drivers/crypto/vmx/Makefile | 21 -
> drivers/crypto/vmx/aes.c | 150 --
> drivers/crypto/vmx/aes_cbc.c | 202 --
> drivers/crypto/vmx/aes_ctr.c | 191 --
> drivers/crypto/vmx/aes_xts.c | 190 --
> drivers/crypto/vmx/aesp8-ppc.h | 25 -
> drivers/crypto/vmx/aesp8-ppc.pl | 3789 -------------------------------------
> drivers/crypto/vmx/ghash.c | 227 ---
> drivers/crypto/vmx/ghashp8-ppc.pl | 234 ---
> drivers/crypto/vmx/ppc-xlate.pl | 228 ---
> drivers/crypto/vmx/vmx.c | 88 -
> 16 files changed, 5377 deletions(-)
> delete mode 100644 drivers/crypto/vmx/.gitignore
> delete mode 100644 drivers/crypto/vmx/Kconfig
> delete mode 100644 drivers/crypto/vmx/Makefile
> delete mode 100644 drivers/crypto/vmx/aes.c
> delete mode 100644 drivers/crypto/vmx/aes_cbc.c
> delete mode 100644 drivers/crypto/vmx/aes_ctr.c
> delete mode 100644 drivers/crypto/vmx/aes_xts.c
> delete mode 100644 drivers/crypto/vmx/aesp8-ppc.h
> delete mode 100644 drivers/crypto/vmx/aesp8-ppc.pl
> delete mode 100644 drivers/crypto/vmx/ghash.c
> delete mode 100644 drivers/crypto/vmx/ghashp8-ppc.pl
> delete mode 100644 drivers/crypto/vmx/ppc-xlate.pl
> delete mode 100644 drivers/crypto/vmx/vmx.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1b0a87ffffab..fd4cbf046ab4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6190,18 +6190,6 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git
> S: Maintained
> F: arch/ia64/
>
> -IBM Power VMX Cryptographic instructions
> -M: Leonidas S. Barbosa <leosilva@linux.vnet.ibm.com>
> -M: Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com>
Any reason why you didn't cc: these maintainers on your patch?
thanks,
greg k-h
next prev parent reply other threads:[~2017-03-29 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 12:56 [PATCH] crypto: vmx: Remove dubiously licensed crypto code Michal Suchanek
2017-03-29 14:51 ` Greg Kroah-Hartman [this message]
2017-03-29 15:13 ` Michal Suchánek
2017-03-29 23:08 ` Tyrel Datwyler
2017-03-30 16:30 ` Paulo Flabiano Smorigo
2017-04-13 13:30 ` Michal Suchánek
2017-05-05 13:52 ` Michal Suchánek
2017-05-05 18:11 ` Benjamin Herrenschmidt
2017-03-29 23:29 ` Tyrel Datwyler
[not found] ` <87r31flisi.fsf@concordia.ellerman.id.au>
2017-03-30 0:49 ` Tyrel Datwyler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329145135.GA28057@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=herbert@gondor.apana.org.au \
--cc=leosilva@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mchehab@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=paulus@samba.org \
--cc=pfsmorigo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).