From: Sebastian Reichel <sre@kernel.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>, Pavel Machek <pavel@ucw.cz>,
Lee Jones <lee.jones@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/2] leds: cpcap: new driver
Date: Wed, 29 Mar 2017 23:38:42 +0200 [thread overview]
Message-ID: <20170329213842.5xsmyfl64iy5qs6n@earth> (raw)
In-Reply-To: <b3a00d96-7eda-4f7f-62f8-364954449b6b@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2210 bytes --]
Hi,
On Wed, Mar 29, 2017 at 09:12:57PM +0200, Jacek Anaszewski wrote:
> On 03/24/2017 09:47 AM, Sebastian Reichel wrote:
> > Motorola CPCAP is a PMIC (power management integrated circuit) found
> > in multiple smartphones. This driver adds support for the chip's LED
> > controllers. This introduces support for all controllers used by the
> > Droid 4. According to Motorola's driver (no datasheets available)
> > there a couple of more LED controllers. I did not add support for
> > them, since I cannot verify that they work with my modifications.
> >
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > ---
> > Changes since PATCHv1:
> > - binding: reference common led binding for label
> > - drop DEBUG define (leftover)
> > - s/led/LED/g in debug prints
> > - order includes alphabetically
> > - introduce mutex, since led API is not atomic
> > - register led class after initial register setup
> > - use GPLv2+ in header
> > - drop unsupported leds from driver
> >
> > Changes since PATCHv2:
> > - use standard defines instead CPCAP_LED_OFF and CPCAP_LED_ON
> >
> > Notes:
> > - The "motorola" vendor-prefix is added via rtc-next
> > ---
> > .../devicetree/bindings/leds/cpcap-leds.txt | 29 +++
> > drivers/leds/Kconfig | 9 +
> > drivers/leds/Makefile | 1 +
> > drivers/leds/leds-cpcap.c | 239 +++++++++++++++++++++
> > 4 files changed, 278 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/cpcap-leds.txt
> > create mode 100644 drivers/leds/leds-cpcap.c
> >
> > diff --git a/Documentation/devicetree/bindings/leds/cpcap-leds.txt b/Documentation/devicetree/bindings/leds/cpcap-leds.txt
> > new file mode 100644
> > index 000000000000..ebf7cdc7f70c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/cpcap-leds.txt
>
> I've changed cpcap-leds.txt to leds-cpcap.txt to match the prevailing
> pattern for LED DT bindings file names.
>
> Please let me know if you have any objections.
Acked-by: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-29 21:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 8:47 [PATCHv3 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel
2017-03-24 8:47 ` [PATCHv3 2/2] leds: cpcap: new driver Sebastian Reichel
2017-03-29 19:12 ` Jacek Anaszewski
2017-03-29 21:38 ` Sebastian Reichel [this message]
2017-03-24 20:44 ` [PATCHv3 1/2] mfd: cpcap: Add missing include dependencies Jacek Anaszewski
2017-03-27 14:26 ` Lee Jones
2017-03-27 18:38 ` Jacek Anaszewski
2017-03-28 8:16 ` Lee Jones
2017-03-28 8:13 ` [GIT PULL] Immutable branch between MFD and LEDS due for the v4.12 merge window Lee Jones
2017-03-28 19:37 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329213842.5xsmyfl64iy5qs6n@earth \
--to=sre@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).