linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval@gmail.com>
To: Keerthy <j-keerthy@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	rui.zhang@intel.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	robh+dt@kernel.org, t-kristo@ti.com
Subject: Re: [PATCH v2 0/8] thermal: ti-soc-thermal: Migrate slope/offset data to device tree
Date: Wed, 29 Mar 2017 21:46:19 -0700	[thread overview]
Message-ID: <20170330044617.GA12753@localhost.localdomain> (raw)
In-Reply-To: <5380b1bc-f3c6-a0ef-e458-7509d95d631e@ti.com>

On Thu, Mar 30, 2017 at 08:59:31AM +0530, Keerthy wrote:
> 
> 
> On Wednesday 29 March 2017 10:07 AM, Eduardo Valentin wrote:
> > Keerthy,
> > 
> > On Fri, Mar 24, 2017 at 07:26:10AM -0700, Tony Lindgren wrote:
> >> * Keerthy <j-keerthy@ti.com> [170323 20:29]:
> >>>
> >>>
> >>> On Friday 24 March 2017 02:22 AM, Tony Lindgren wrote:
> >>>> * Keerthy <j-keerthy@ti.com> [170321 20:45]:
> >>>>>
> >>>>>
> >>>>> On Thursday 09 March 2017 01:35 PM, Keerthy wrote:
> >>>>>> Currently the slope and offset values for calculating the
> >>>>>> hot spot temperature of a particular thermal zone is part
> >>>>>> of driver data. Pass them here instead and obtain the values
> >>>>>> while of node parsing.
> >>>>>>
> >>>>>> Tested for the slope and constant values on DRA7-EVM, OMAP3-BEAGLE. 
> > 
> > Have you tried on boards that need negative coefficients?
> > 
> > https://patchwork.kernel.org/patch/9619577/
> 
> Yes. I retrieved the negative values nicely in the driver passed via
> Device Tree.
> 
> > 
> >>>>>
> >>>>> Hi Eduardo,
> >>>>>
> >>>>> If the series looks okay could you please pull this?
> >>>>
> >>>> Also.. Are the dts changes safe for me to pick separately?
> >>>
> >>> Yes Tony they are safe to pulled separately.
> >>
> >> OK applying patches 1 - 5 of this series into omap-for-v4.12/dt-v2.
> > 
> > Keerthy,
> > 
> > The only thing I want you to confirm is if you are really getting the
> > negative coefficients, because currently of-thermal reads the array
> > using an OF helper that understands only unsigned. For this reason, I
> > will be queueing your patches only for next merge window, not as a fix,
> > not for rc's.
> 
> I am getting negative co-efficients.

OK. That is odd. Might be simply we get still converted after simply
assigning the unsigned to the int in the thermal device data struct.
Anyways, still not for rc, given the amount of changes in the driver.

> 
> > 
> > 
> >>
> >> Thanks,
> >>
> >> Tony

      reply	other threads:[~2017-03-30  4:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09  8:05 [PATCH v2 0/8] thermal: ti-soc-thermal: Migrate slope/offset data to device tree Keerthy
2017-03-09  8:05 ` [PATCH v2 1/8] arm: dts: omap3: Add cpu_thermal zone Keerthy
2017-03-09  8:05 ` [PATCH v2 2/8] ARM: DRA7: Thermal: Add slope and offset values Keerthy
2017-03-09  8:05 ` [PATCH v2 3/8] ARM: OMAP5: " Keerthy
2017-03-29  4:33   ` Eduardo Valentin
2017-03-30  3:27     ` Keerthy
2017-03-09  8:05 ` [PATCH v2 4/8] ARM: OMAP443x: " Keerthy
2017-03-09  8:05 ` [PATCH v2 5/8] ARM: OMAP4460: " Keerthy
2017-03-09  8:06 ` [PATCH v2 6/8] thermal: ti-soc-thermal: Fetch slope and offset from DT Keerthy
2017-03-09  8:06 ` [PATCH v2 7/8] thermal: ti-soc-thermal: Remove redundant constants Keerthy
2017-03-09  8:06 ` [PATCH v2 8/8] thermal: ti-soc-thermal: Remove redundant code Keerthy
2017-03-22  3:42 ` [PATCH v2 0/8] thermal: ti-soc-thermal: Migrate slope/offset data to device tree Keerthy
2017-03-23 20:52   ` Tony Lindgren
2017-03-24  3:26     ` Keerthy
2017-03-24 14:26       ` Tony Lindgren
2017-03-29  4:37         ` Eduardo Valentin
2017-03-30  3:29           ` Keerthy
2017-03-30  4:46             ` Eduardo Valentin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170330044617.GA12753@localhost.localdomain \
    --to=edubezval@gmail.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).