From: Gioh Kim <gi-oh.kim@profitbricks.com>
To: NeilBrown <neilb@suse.com>
Cc: jes.sorensen@gmail.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, Wol <anthony@youngman.org.uk>
Subject: Re: [PATCH 2/2] mdadm.c: fix compile error "switch condition has boolean value"
Date: Thu, 30 Mar 2017 09:52:10 +0200 [thread overview]
Message-ID: <20170330075209.GF17378@ws00837> (raw)
In-Reply-To: <87lgrnu5k4.fsf@notabene.neil.brown.name>
On Thu, Mar 30, 2017 at 08:38:35AM +1100, NeilBrown wrote:
> On Thu, Mar 30 2017, jes.sorensen@gmail.com wrote:
>
> > Gioh Kim <gi-oh.kim@profitbricks.com> writes:
> >> Remove a boolean expression in switch condition
> >> to prevent compile error of some compilers.
> >
> > Please be specific, which compile is unable to handle this?
> >
> >> Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
> >> ---
> >> mdadm.c | 6 +++---
> >> 1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/mdadm.c b/mdadm.c
> >> index 08ddcab..a98a051 100644
> >> --- a/mdadm.c
> >> +++ b/mdadm.c
> >> @@ -1905,11 +1905,11 @@ static int misc_list(struct mddev_dev *devlist,
> >> rv |= SetAction(dv->devname, c->action);
> >> continue;
> >> }
> >> - switch(dv->devname[0] == '/') {
> >> - case 0:
> >> + switch(dv->devname[0]) {
> >> + default:
> >> mdfd = open_dev(dv->devname);
> >> if (mdfd >= 0) break;
> >> - case 1:
> >> + case '/':
> >> mdfd = open_mddev(dv->devname, 1);
> >> }
> >> if (mdfd>=0) {
> >
> > While I agree the original code is ugly, I am not convinced your
> > replacement is a lot prettier.
> >
>
> Maybe
>
> if (dv->devname[0] == '/' ||
> (mdfd = open_dev(dv->devname)) < 0)
> mdfd = open_mddev(dv->devname, 1);
>
> ??
> NeilBrown
Yes, the initial version I thought was:
if (dev->devname[0] != '/')
mdfd = open_dev(dv->devname);
if (dev->devname[0] == '/' || mdfd < 0)
mdfd = open_mddev(dv->devname, 1);
But I thought you have a reason to use switch-case expression,
so I kept switch-case.
If you agree, I'll send v2 patch using if-expression.
--
Best regards,
Gi-Oh Kim
TEL: 0176 2697 8962
next prev parent reply other threads:[~2017-03-30 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 9:40 [PATCH 1/2] super1: replace hard-coded values with bit definitions Gioh Kim
2017-03-29 9:40 ` [PATCH 2/2] mdadm.c: fix compile error "switch condition has boolean value" Gioh Kim
2017-03-29 15:47 ` jes.sorensen
2017-03-29 15:50 ` Gioh Kim
2017-03-29 21:38 ` NeilBrown
2017-03-30 7:52 ` Gioh Kim [this message]
2017-03-30 15:53 ` Jes Sorensen
2017-03-29 15:41 ` [PATCH 1/2] super1: replace hard-coded values with bit definitions jes.sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330075209.GF17378@ws00837 \
--to=gi-oh.kim@profitbricks.com \
--cc=anthony@youngman.org.uk \
--cc=jes.sorensen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).