From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 3/9] net: dsa: mv88e6xxx: program the PVT with all ones
Date: Thu, 30 Mar 2017 15:45:21 +0200 [thread overview]
Message-ID: <20170330134521.GC17879@lunn.ch> (raw)
In-Reply-To: <20170329203020.27042-4-vivien.didelot@savoirfairelinux.com>
> + for (dev = 0; dev < 32; ++dev) {
> + for (port = 0; port < 16; ++port) {
> + err = mv88e6xxx_pvt_map(chip, dev, port);
> + if (err)
> + return err;
> + }
> + }
> +
> + return 0;
Hi Vivien
How about adding MV88E6XXX_MAX_PVT_SWITCHES and MV88E6XXX_MAX_PVT_PORTS?
> +static int mv88e6xxx_g2_pvt_op(struct mv88e6xxx_chip *chip, int src_dev,
> + int src_port, u16 op)
> +{
> + int err;
> +
> + /* 9-bit Cross-chip PVT pointer: with GLOBAL2_MISC_5_BIT_PORT cleared,
> + * source device is 5-bit, source port is 4-bit.
> + */
> + op |= (src_dev & 0x1f) << 4;
> + op |= (src_port & 0xf);
So here, are you hard coding the knowledge that we passed false to
mv88e6xxx_g2_misc_5_bit_port()? It kind of defeats the point of
having the parameter. Maybe simplify the code and remove the
parameter?
Andrew
next prev parent reply other threads:[~2017-03-30 13:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 20:30 [PATCH net-next 0/9] net: dsa: mv88e6xxx: program cross-chip bridging Vivien Didelot
2017-03-29 20:30 ` [PATCH net-next 1/9] net: dsa: mv88e6xxx: move PVT description in info Vivien Didelot
2017-03-30 13:31 ` Andrew Lunn
2017-03-29 20:30 ` [PATCH net-next 2/9] net: dsa: mv88e6xxx: use 4-bit port for PVT data Vivien Didelot
2017-03-30 13:34 ` Andrew Lunn
2017-03-29 20:30 ` [PATCH net-next 3/9] net: dsa: mv88e6xxx: program the PVT with all ones Vivien Didelot
2017-03-30 13:45 ` Andrew Lunn [this message]
2017-03-30 14:16 ` Vivien Didelot
2017-03-29 20:30 ` [PATCH net-next 4/9] net: dsa: mv88e6xxx: allocate the number of ports Vivien Didelot
2017-03-30 13:50 ` Andrew Lunn
2017-03-30 14:06 ` Vivien Didelot
2017-03-29 20:30 ` [PATCH net-next 5/9] net: dsa: mv88e6xxx: rework in-chip bridging Vivien Didelot
2017-03-30 13:57 ` Andrew Lunn
2017-03-29 20:30 ` [PATCH net-next 6/9] net: dsa: mv88e6xxx: factorize in-chip bridge map Vivien Didelot
2017-03-30 14:04 ` Andrew Lunn
2017-03-29 20:30 ` [PATCH net-next 7/9] net: dsa: mv88e6xxx: remap existing bridge members Vivien Didelot
2017-03-30 14:07 ` Andrew Lunn
2017-03-29 20:30 ` [PATCH net-next 8/9] net: dsa: add cross-chip bridging operations Vivien Didelot
2017-03-29 20:30 ` [PATCH net-next 9/9] net: dsa: mv88e6xxx: add cross-chip bridging Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330134521.GC17879@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).