Re: [PATCH v7 00/13] mmc: Add support to Marvell Xenon SD Host Controller - Russell King

From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-mmc@vger.kernel.org, Jimmy Xu <zmxu@marvell.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Mike Turquette <mturquette@baylibre.com>,
	Nadav Haklai <nadavh@marvell.com>, Ziji Hu <huziji@marvell.com>,
	Victor Gu <xigu@marvell.com>, Doug Jones <dougj@marvell.com>,
	linux-clk@vger.kernel.org, Jisheng Zhang <jszhang@marvell.com>,
	Yehuda Yitschak <yehuday@marvell.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Kostya Porotchkin <kostap@marvell.com>,
	Hanna Hawa <hannah@marvell.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
	Rob Herring <robh+dt@kernel.org>, Ryan Gao <ygao@marvell.com>,
	"Wei(SOCP) Liu" <liuw@marvell.com>,
	linux-arm-kernel@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-kernel@vger.kernel.org, Wilson Ding <dingwei@marvell.com>
Subject: Re: [PATCH v7 00/13] mmc: Add support to Marvell Xenon SD Host Controller
Date: Thu, 30 Mar 2017 19:56:39 +0100	[thread overview]
Message-ID: <20170330185639.GI7909@n2100.armlinux.org.uk> (raw)
In-Reply-To: <cover.51071caa64e5df81264a91b9a81ed1e94f47d2c4.1490886907.git-series.gregory.clement@free-electrons.com>

On Thu, Mar 30, 2017 at 05:22:52PM +0200, Gregory CLEMENT wrote:
> - Remove parse of child node mmc-card. Wait for a better solution.

So for mcbin, I have:

&ap_sdhci0 {
        bus-width = <8>;
        marvell,xenon-emmc;
        marvell,xenon-phy-type = "emmc 5.1 phy";
        /*
         * Not stable in HS modes - phy needs "more calibration", so add
         * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
         */
        marvell,xenon-phy-slow-mode;
        no-1-8-v;
        non-removable;
        status = "okay";
        vqmmc-supply = <&v_vddo_h>;

        #address-cells = <1>;
        #size-cells = <0>;
        mmccard: mmccard@0 {
                compatible = "mmc-card";
                reg = <0>;
        };
};

Does this mean the "mmccard" bit is no longer required - or is it required
for the eMMC to be detected but is no longer supported by the driver?

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.