From: Rob Herring <robh@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: wsa@the-dreams.de, mark.rutland@arm.com, tglx@linutronix.de,
jason@lakedaemon.net, marc.zyngier@arm.com, joel@jms.id.au,
vz@mleia.com, mouse@mayc.ru, clg@kaod.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
benh@kernel.crashing.org
Subject: Re: [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver
Date: Mon, 3 Apr 2017 09:24:10 -0500 [thread overview]
Message-ID: <20170403142410.57qqtuvawu3qon2m@rob-hp-laptop> (raw)
In-Reply-To: <20170328051226.21677-4-brendanhiggins@google.com>
On Mon, Mar 27, 2017 at 10:12:24PM -0700, Brendan Higgins wrote:
> Added device tree binding documentation for Aspeed I2C busses.
>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
> Changes for v2:
> - None
> Changes for v3:
> - Removed reference to "bus" device tree param
> Changes for v4:
> - None
> Changes for v5:
> - None
> Changes for v6:
> - Replaced the controller property with and interrupt controller, leaving only
> the busses in the I2C documentation.
> ---
> .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 ++++++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
> new file mode 100644
> index 000000000000..fbcc501706b1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-aspeed.txt
> @@ -0,0 +1,49 @@
> +Device tree configuration for the I2C busses on the AST24XX and AST25XX SoCs.
> +
> +Required Properties:
> +- #address-cells : should be 1
> +- #size-cells : should be 0
> +- reg : address offset and range of bus
> +- compatible : should be "aspeed,ast2400-i2c-bus"
> + or "aspeed,ast2500-i2c-bus"
> +- clocks : root clock of bus, should reference the APB
> + clock
> +- interrupts : interrupt number
> +- interrupt-parent : interrupt controller for bus, should reference a
> + aspeed,ast2400-i2c-ic or aspeed,ast2500-i2c-ic
> + interrupt controller
> +
> +Optional Properties:
> +- clock-frequency : frequency of the bus clock in Hz
> + defaults to 100 kHz when not specified
> +
> +Example:
> +
> +i2c {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x1e78a000 0x1000>;
> +
> + i2c_ic: interrupt-controller@0 {
> + #interrupt-cells = <1>;
> + compatible = "aspeed,ast2400-i2c-ic";
> + reg = <0x0 0x40>;
> + interrupts = <12>;
> + interrupt-controller;
> + };
> +
> + i2c0: i2c-bus@40 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #interrupt-cells = <1>;
> + reg = <0x40 0x40>;
> + compatible = "aspeed,ast2400-i2c-bus";
> + bus = <0>;
Not documented and what's it for?
> + clocks = <&clk_apb>;
> + clock-frequency = <100000>;
> + status = "disabled";
Drop status from examples.
> + interrupts = <0>;
> + interrupt-parent = <&i2c_ic>;
> + };
> +};
> --
> 2.12.2.564.g063fe858b8-goog
>
next prev parent reply other threads:[~2017-04-03 14:24 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 5:12 [PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-03-28 5:12 ` [PATCH v6 1/5] irqchip/aspeed-i2c-ic: binding docs for Aspeed I2C Interrupt Controller Brendan Higgins
2017-03-28 8:49 ` Benjamin Herrenschmidt
2017-03-29 10:34 ` Brendan Higgins
2017-03-29 12:11 ` Benjamin Herrenschmidt
2017-03-29 20:51 ` Brendan Higgins
2017-03-29 21:17 ` Benjamin Herrenschmidt
2017-04-03 14:16 ` Rob Herring
2017-03-28 5:12 ` [PATCH v6 2/5] irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed Brendan Higgins
2017-03-28 8:32 ` Marc Zyngier
2017-03-28 9:12 ` Benjamin Herrenschmidt
2017-03-28 9:40 ` Marc Zyngier
2017-03-28 20:50 ` Benjamin Herrenschmidt
2017-03-29 9:59 ` Brendan Higgins
2017-03-29 10:55 ` Marc Zyngier
2017-03-28 8:52 ` Benjamin Herrenschmidt
2017-03-29 10:58 ` Joel Stanley
2017-03-29 20:16 ` Brendan Higgins
2017-03-28 5:12 ` [PATCH v6 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins
2017-03-28 8:54 ` Benjamin Herrenschmidt
2017-03-29 10:25 ` Brendan Higgins
2017-04-03 14:22 ` Rob Herring
2017-04-03 14:24 ` Rob Herring [this message]
2017-03-28 5:12 ` [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-03-28 8:57 ` Benjamin Herrenschmidt
2017-03-28 9:09 ` Benjamin Herrenschmidt
2017-03-29 10:23 ` Brendan Higgins
2017-03-31 0:33 ` Joel Stanley
2017-03-31 7:33 ` Benjamin Herrenschmidt
2017-04-24 18:56 ` Brendan Higgins
2017-04-25 2:19 ` Benjamin Herrenschmidt
2017-04-25 8:32 ` Brendan Higgins
2017-04-25 8:50 ` Ryan Chen
2017-04-25 9:34 ` Benjamin Herrenschmidt
2017-04-25 9:47 ` Ryan Chen
2017-04-25 19:50 ` Brendan Higgins
2017-04-26 0:52 ` Ryan Chen
2017-03-28 5:12 ` [PATCH v6 5/5] i2c: aspeed: added slave support for Aspeed I2C driver Brendan Higgins
2017-03-31 0:01 ` [PATCH v6 0/5] i2c: aspeed: added driver for Aspeed I2C Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403142410.57qqtuvawu3qon2m@rob-hp-laptop \
--to=robh@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mouse@mayc.ru \
--cc=openbmc@lists.ozlabs.org \
--cc=tglx@linutronix.de \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).