From: Rob Herring <robh@kernel.org>
To: Ryan Lee <ryans.lee@maximintegrated.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com,
perex@perex.cz, tiwai@suse.com, kuninori.morimoto.gx@renesas.com,
arnd@arndb.de, ckeepax@opensource.wolfsonmicro.com,
lars@metafoo.de, bardliao@realtek.com, nh6z@nh6z.net,
KCHSU0@nuvoton.com, axel.lin@ingics.com,
romain.perier@collabora.com, srinivas.kandagatla@linaro.org,
oder_chiou@realtek.com, Paul.Handrigan@cirrus.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dgreid@google.com,
ryan.lee.maxim@gmail.com
Subject: Re: [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier
Date: Mon, 3 Apr 2017 11:30:53 -0500 [thread overview]
Message-ID: <20170403163053.u6b3yadkfyh4z7h5@rob-hp-laptop> (raw)
In-Reply-To: <1490922994-19294-1-git-send-email-ryans.lee@maximintegrated.com>
On Fri, Mar 31, 2017 at 10:16:34AM +0900, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
>
> Changes since v4:
> * Removed support for SND_SOC_DAIFMT_CBS_CFM.
> * Fixed coding style for indention.
> * Removed variables if it has only one user.
> * Assigned ch_size directly.
> * Removed oring.
> * Put the return false in the switch statement.
> * Removed 'Monomix Output' and 'Speaker Source' controls.
> * Modified control names per control-names.rst.
> * Moved Revision ID check code to i2c_probe function.
> * Added 'Current Limit' control.
> * Removed 'devm__kfree' function.
>
> Changes since v3:
> * Combined MAX98926 and MAX98927 binding. Kept existing property name.
This looks fine, but:
> Changes since v2:
> * Removed local register read/write function to avoid duplication of ASoC core function.
>
> .../devicetree/bindings/sound/max98925.txt | 22 -
> .../devicetree/bindings/sound/max98926.txt | 32 -
> .../devicetree/bindings/sound/max9892x.txt | 41 +
> sound/soc/codecs/Kconfig | 5 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/max98927.c | 841 +++++++++++++++++++++
> sound/soc/codecs/max98927.h | 272 +++++++
> 7 files changed, 1161 insertions(+), 54 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/max98925.txt
> delete mode 100644 Documentation/devicetree/bindings/sound/max98926.txt
> create mode 100755 Documentation/devicetree/bindings/sound/max9892x.txt
> mode change 100644 => 100755 sound/soc/codecs/Kconfig
> mode change 100644 => 100755 sound/soc/codecs/Makefile
> create mode 100755 sound/soc/codecs/max98927.c
> create mode 100755 sound/soc/codecs/max98927.h
These should all be 644 mode.
Rob
next prev parent reply other threads:[~2017-04-03 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 1:16 [PATCH v4] ASoC: Add support for Maxim Integrated MAX98927 Amplifier Ryan Lee
2017-04-03 16:30 ` Rob Herring [this message]
2017-04-03 17:24 ` Ryan Lee
2017-04-06 18:55 ` Applied "ASoC: Add support for Maxim Integrated MAX98927 Amplifier" to the asoc tree Mark Brown
2017-04-07 21:29 ` Ryan Lee
2017-04-25 16:24 ` Ryan Lee
2017-04-25 16:28 ` Mark Brown
2017-04-25 16:51 ` Ryan Lee
2017-04-26 2:51 ` Ryan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403163053.u6b3yadkfyh4z7h5@rob-hp-laptop \
--to=robh@kernel.org \
--cc=KCHSU0@nuvoton.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=axel.lin@ingics.com \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@google.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nh6z@nh6z.net \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=romain.perier@collabora.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).