From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbdDCVSl (ORCPT ); Mon, 3 Apr 2017 17:18:41 -0400 Received: from mail.kernel.org ([198.145.29.136]:56226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750945AbdDCVSj (ORCPT ); Mon, 3 Apr 2017 17:18:39 -0400 Date: Mon, 3 Apr 2017 16:18:35 -0500 From: Bjorn Helgaas To: Arnd Bergmann Cc: Bjorn Helgaas , Kishon Vijay Abraham I , Jingoo Han , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci: dwc: hisi needs PCI_HOST_COMMON Message-ID: <20170403211835.GD13232@bhelgaas-glaptop.roam.corp.google.com> References: <20170321143229.3372903-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170321143229.3372903-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2017 at 03:32:11PM +0100, Arnd Bergmann wrote: > Without PCI_HOST_COMMON support enabled, we get a link error: > > drivers/pci/dwc/built-in.o: In function `hisi_pcie_map_bus': > pcie-hisi.c:(.text+0x8860): undefined reference to `pci_ecam_map_bus' > drivers/pci/dwc/built-in.o: In function `hisi_pcie_almost_ecam_probe': > pcie-hisi.c:(.text+0x88b4): undefined reference to `pci_host_common_probe' > > This adds an explicit 'select', as the other users have. > > Signed-off-by: Arnd Bergmann Applied with Jingoo's ack to for-linus for v4.11, since this got broken in the v4.11 merge window. > --- > drivers/pci/dwc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/dwc/Kconfig b/drivers/pci/dwc/Kconfig > index dfb8a69afc28..d2d2ba5b8a68 100644 > --- a/drivers/pci/dwc/Kconfig > +++ b/drivers/pci/dwc/Kconfig > @@ -89,6 +89,7 @@ config PCI_HISI > depends on PCI_MSI_IRQ_DOMAIN > select PCIEPORTBUS > select PCIE_DW_HOST > + select PCI_HOST_COMMON > help > Say Y here if you want PCIe controller support on HiSilicon > Hip05 and Hip06 SoCs > -- > 2.9.0 >